fix: resolve worksheet-drawing scheme colors against workbook theme#434
Merged
Conversation
developer0hye
force-pushed
the
fix/xlsx-drawing-theme-colors
branch
from
July 24, 2026 08:52
b62dd4e to
ad7d36f
Compare
Owner
Author
|
The Visual PR Contract check fails on I tried to produce the missing ground truth from the PR's own fixture and could not:
The fixture is a hand-built eight-entry archive with no Two ways forward:
I did not change the PR because the choice of fixture is a design decision for this change. |
This was referenced Jul 25, 2026
Read the workbook theme palette and resolve worksheet drawing scheme colors through the shared DrawingML color parser, including tint, shade, luminance, and spreadsheet bg/tx aliases. Preserve the historical light/dark fallback when a theme cannot be read. Add an Excel-authored one-page regression fixture, parser and integration coverage, and 150 DPI native-Excel/before/after evidence for issue #430. Independent drawing layout and font deviations remain tracked in #459, #460, #461, and #462. Fixes #430 Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
developer0hye
force-pushed
the
fix/xlsx-drawing-theme-colors
branch
from
July 25, 2026 13:50
ad7d36f to
e61a6fa
Compare
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schemeClrfills against the workbook themelumMod,lumOff, tint, and shadeRelated issue
Fixes #430
Testing
cargo fmt --all -- --checkCARGO_TARGET_DIR=/private/tmp/office2pdf-pr-434-target cargo test --workspace -j 1CARGO_TARGET_DIR=/private/tmp/office2pdf-pr-434-target cargo clippy --workspace --all-targets --all-features -j 1 -- -D warningsCARGO_TARGET_DIR=/private/tmp/office2pdf-pr-434-target cargo test -p office2pdf --test xlsx_fixtures theme_color_drawingpython3 -m unittest scripts.tests.test_check_visual_prscripts/macos/export_excel_pdfs.applescriptpdfinfopage-count and page-size inspectionpdftoppm -r 150rendering, full-resolution matched crops, andmagick compare -metric AE -fuzz 5%#4472C4,#B4C7E7,#548235Visual impact
Visual audit
tests/fixtures/xlsx/theme_color_drawing.xlsxpdftoppm, 150 DPIfixassets/bugfixes/issue-430/gt.jpgassets/bugfixes/issue-430/before.jpgassets/bugfixes/issue-430/after.jpgVisual comparison
Required inspection
The normalized GT/after comparison has 289,249 differing pixels at 5% fuzz. Every highlighted cluster is explained by the open issues below. The fixture has no hairlines, borders, bold, italic, or underlined runs; all text is regular weight.
Deviation audit
Checklist
Signed-off-byline