feat: runtime-split-validation validation#52
Merged
takemi-ohama merged 3 commits intoJul 7, 2026
Conversation
15 tasks
takemi-ohama
force-pushed
the
feature/runtime-split-validation
branch
from
edce3f5 to
2824f67
Compare
takemi-ohama
commented
Jul 7, 2026
takemi-ohama
left a comment
takemi-ohama
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 cross-review | round 1 | codex | REQUEST_CHANGES(intent)
生成物同期、manifest/source 存在、CI 実行性、hooks の安全性は概ね妥当で、ローカルでも bash scripts/validate-runtime-plugins.sh は成功しました。
ただし、Kiro installer 検証が --help で終了していて install/dry-run 経路を検証していない点と、Markdown link parser が標準的なタイトル付き相対リンクを false positive にする点は、この PR の検証目的に対して修正が必要です。
takemi-ohama
commented
Jul 7, 2026
takemi-ohama
left a comment
takemi-ohama
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 cross-review | round 2 | codex | APPROVE(intent)
✅ 概要
scripts/validate-runtime-plugins.shが Kiro installer を--dry-run/--dry-run --with-codexで呼び出すようになり、実際に両方の dry-run が問題なく完了することを確認しました。scripts/check-markdown-links.pyにタイトル除去の正規表現が追加され、タイトル付き相対リンクが誤検出されないことをscripts/check-markdown-links.py --root .の再実行で確認しました。
🔍 検証
bash scripts/validate-runtime-plugins.shbash plugins/ndf-kiro/install.sh --dry-runbash plugins/ndf-kiro/install.sh --dry-run --with-codex
takemi-ohama
commented
Jul 7, 2026
takemi-ohama
left a comment
takemi-ohama
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 cross-review | round 2 | gemini | APPROVE(intent)
PR #52 のround 2レビューを行いました。
scripts/validate-runtime-plugins.shにおいて、Kiroインストーラー (ndf-kiro/install.sh) に対する--dry-runオプションを用いた検証が正しく追加されていることを確認しました。scripts/check-markdown-links.pyにおいて、Markdownリンクのtitle属性を適切にストリップするための処理 (TITLE_RE) が実装され、誤検知 (false positive) の問題が修正されていることを確認しました。- ローカル環境で
bash scripts/validate-runtime-plugins.sh、.githooks/pre-commit、.githooks/pre-pushを実行し、すべての検証が成功することを確認しました。
Codexのround 1での指摘事項はすべて適切に解消されています。素晴らしい対応です。マージ可能です。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/validate-runtime-plugins.shを追加し、生成物同期、JSON / manifest、marketplace source、Kiro installer、Markdown local link を一括検証scripts/check-markdown-links.pyを追加し、repo 相対 Markdown link の欠落を検出.githooks/pre-commit/.githooks/pre-pushとscripts/install-dev-hooks.shを追加runtime-plugin-validate.ymlを追加し、build check / runtime validation / markdown link check を実行Test plan
bash scripts/build-runtime-plugins.sh --checkpython3 scripts/check-markdown-links.py --root .bash -n scripts/validate-runtime-plugins.sh scripts/install-dev-hooks.sh .githooks/pre-commit .githooks/pre-pushbash scripts/validate-runtime-plugins.sh.githooks/pre-commit.githooks/pre-pushbash scripts/install-dev-hooks.shgit diff --checkgit diff --cached --checkbuild-runtime-plugins.sh --checkを実行して成功validate-runtime-plugins.shを実行して成功