feat: runtime-split-codex Codex plugin#48
Merged
takemi-ohama merged 2 commits intoJul 6, 2026
Conversation
15 tasks
takemi-ohama
force-pushed
the
feature/runtime-split-codex
branch
from
b7704a4 to
181f9ef
Compare
takemi-ohama
commented
Jul 6, 2026
takemi-ohama
left a comment
takemi-ohama
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 cross-review | round 1 | codex | APPROVE
修正必須の指摘はありません。
takemi-ohama
commented
Jul 6, 2026
takemi-ohama
left a comment
takemi-ohama
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 cross-review | round 1 | gemini | APPROVE
本 PR の目的である Codex 用 NDF プラグインの分離と、marketplace.json、README.md、hooks.json、plugin.json などの設定更新が正しく行われていることを確認しました。
ランタイム非依存のパス表現への修正も適切です。
[minor / 保守性]
本 PR の目的である「旧 plugins/ndf パスのランタイム非依存表現への更新」に関して、共有ソース側に一部旧パスが残存しています。例えば plugins/ndf-shared/skills/playwright-kit-ops/SKILL.md や関連スクリプト内に export GOOGLE_AUTH_SCRIPTS=/path/to/plugins/ndf/skills/google-auth/scripts の記述が残っています。Codex 版では google-auth skill が除外されている点も含め、後続のドキュメント整理 PR 等で表現の見直しを推奨します。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/ndf-codexを追加し、Codex manifest / hooks / README / generated skills / scripts を単体同梱.agents/plugins/marketplace.jsonのndf.source.pathを./plugins/ndf-codexに切り替えplugins/ndf/skills-codexパスの一部を共通 source から runtime 非依存表現へ更新Test plan
bash scripts/build-runtime-plugins.sh --checkpython3 -m json.tool .agents/plugins/marketplace.json >/dev/nullpython3 -m json.tool plugins/ndf-codex/.codex-plugin/plugin.json >/dev/nullpython3 -m json.tool plugins/ndf-codex/hooks/hooks.json >/dev/nulltest -d plugins/ndf-codex/skillstest -d plugins/ndf-codex/scriptscodex plugin --helpで CLI に validate サブコマンドが無いことを確認し、README 記載の fallback validation を実施