Refactor code structure for improved readability and maintainability - #108
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Explode View for assembly files
Assembly parts explode along geometry-derived axes with a computed
disassembly order, rather than a naive radial spread.
How it works
principal axis for body parts (bores excluded — a hole is where another
part passes through, not an exit path), radial fallback otherwise
plus interlock constraints derived from hole-occupancy (a part with
something through its bore can't move until that part is out)
UI
Toggle, 0–100% slider, Play/Reverse with correct enable/disable states.
Explode state resets on file change and the control is hidden for
non-assemblies.
Known limitations
Automatic ordering is reliable on simple mechanical assemblies (Knuckle
Joint: 5/5 clean) and degrades on denser ones (Stuffing Box: 7/13;
22-part sheet-metal enclosure: 6/22, where mutual blocking between bolts
and large panels cascades into cycle-fallback).
A manual override system (stage reorder, axis override, direction flip)
is implemented and verified but hidden behind
SHOW_EXPLODE_MANUAL_OVERRIDE_UI = false, pending an attempt at
contact-based direction derivation. If that doesn't improve on this
baseline, override should be re-enabled before this reaches users.