feat: enhance accessibility and styling across the application with s… - #100
Merged
Conversation
…emantic HTML and improved button colors
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
1. Code-split the CAD viewer away from non-viewer routes (main fix)
App(the full CAD viewer engine — Three.js, OpenCascade WASM wiring) was statically imported inmain.tsx, the shared entry point for every route. Even though/viewerwraps it in<ClientOnly>, that only prevents server-rendering — the browser was still downloading and parsing the entire viewer bundle on the landing page and guide pages, which never use it at all.React.lazy(() => import("./ui/App"))+<Suspense>, so it's now a separate chunk only fetched when someone actually navigates to/viewer/and/guides/split-step-assemblyno longer fetch the viewer chunk or its WASM worker at all2. Fixed insufficient button contrast
#3b82f6measured 3.68:1, failing WCAG AA (needs 4.5:1)#2563eb(5.17:1, passes),#1d4ed8on hover — applied to both the landing page CTA and the viewer header's Upload button3. Added
<main>landmark4. Fixed llms.txt link formatting
[text](url)formatWhy
Validation
/viewerloaded and fully tested: file upload, orbit, Measure, Wireframe toggle, view-cube (FRONT face confirmed) all functional after lazy-loadingtypecheckandlintcleanNotes
SHOW_WIREFRAME_DENSITY_CONTROLS = false) — unrelated pre-existing state, not touched by this work