rough implementation of a capture filter#45
Conversation
fix typechecking issues (in possibly the worst way i could think of)
|
opening this up because it is working now! |
|
Hi! Thank you for this awsome contribution! I'm still reviewing, I'd just like to leave a few notes.
|
Apologies for the styling changes, my IDE applied them automatically. |
|
Hey! Thought I'd just drop this here just in case; Haven't read the PR, maybe this has nothing to do with that, but I did want to say that so you are aware in case this does take a second to be reviewed. Is this change something you need for one of your projects? If so I can probably get around to it sooner than usual, just need to know if this is an important thing or not. Thanks for the contribution! |
There was a problem hiding this comment.
Good catch,
For context, Sentry specifically steers clear of language of this sort, and we are trying to align to their engineering philosophy.
See here: https://develop.sentry.dev/getting-started/inclusive-language/
fix typechecking issues (in possibly the worst way i could think of)
this is untested! i'm still working on this :)