Skip to content

rough implementation of a capture filter#45

Open
imskyyc wants to merge 8 commits into
devSparkle:mainfrom
imskyyc:main
Open

rough implementation of a capture filter#45
imskyyc wants to merge 8 commits into
devSparkle:mainfrom
imskyyc:main

Conversation

@imskyyc

@imskyyc imskyyc commented Mar 25, 2026

Copy link
Copy Markdown

fix typechecking issues (in possibly the worst way i could think of)

this is untested! i'm still working on this :)

@imskyyc imskyyc marked this pull request as ready for review March 26, 2026 22:16
@imskyyc

imskyyc commented Mar 26, 2026

Copy link
Copy Markdown
Author

opening this up because it is working now!

@devSparkle devSparkle self-assigned this Apr 4, 2026
@devSparkle

Copy link
Copy Markdown
Owner

Hi!

Thank you for this awsome contribution! I'm still reviewing, I'd just like to leave a few notes.

  1. I've gone ahead and reverted style changes — it was making it difficult to distinguish between styling and code changes, which was hampering review. If you'd like to propose style changes, I'm more than happy to consider them in a seperate commit.
  2. Thanks for the added support of the SDK as a Git Submodule! I'll be testing this seperately, and if it checks out cherry-picking the commit onto main.

@imskyyc

imskyyc commented Apr 4, 2026

Copy link
Copy Markdown
Author

Hi!

Thank you for this awsome contribution! I'm still reviewing, I'd just like to leave a few notes.

  1. I've gone ahead and reverted style changes — it was making it difficult to distinguish between styling and code changes, which was hampering review. If you'd like to propose style changes, I'm more than happy to consider them in a seperate commit.
  2. Thanks for the added support of the SDK as a Git Submodule! I'll be testing this seperately, and if it checks out cherry-picking the commit onto main.

Apologies for the styling changes, my IDE applied them automatically.

@Asynchronite

Copy link
Copy Markdown
Collaborator

@devSparkle ^

@Asynchronite

Copy link
Copy Markdown
Collaborator

Hey! Thought I'd just drop this here just in case;
With Roblox's 717 release, they introduce more logging "levels", and we would like to implement them into this SDK as soon as possible.
PR #43 already sort of implements this, but it was created before this update was published I believe, so we have to probably change stuff on that front.

Haven't read the PR, maybe this has nothing to do with that, but I did want to say that so you are aware in case this does take a second to be reviewed.

Is this change something you need for one of your projects? If so I can probably get around to it sooner than usual, just need to know if this is an important thing or not.

Thanks for the contribution!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch,
For context, Sentry specifically steers clear of language of this sort, and we are trying to align to their engineering philosophy.

See here: https://develop.sentry.dev/getting-started/inclusive-language/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants