Discussion: adds local storage clearing

[fdoflorenzano]

Moving a conversation started in #150 here:

One thing that worried me about the #140 was that it maybe resets values for the inputs too frequently, even if it's not needed in certain scenarios. Like maybe an number input value I tweaked into a very specific value already in the UI, but if I tweak the max value in the definition it will reset the current value. But of course, what if that max value is smaller than the current value? There may be a lot of edge cases that are weird to control, but at some point we could introduce smarter resets. The current setup is simpler in that sense.

But another thing I worry it introduces is adding much more new entries in local storage. I started worrying back when we introduced seed history storage, cause this too already seems like a lot saved there. So here I also add a little clearLocalStorage function that could be called from the UI in certain scenarios (like debugging or something crashes and we add to the error log that they can clear it). Tho I don't know yet how or where to add that in the UI. Any ideas welcome :)

Lucas thoughts:

I'm just leaving some initial ideas here:

• I'm not sure how much of an issue too many local storage entries are performance wise, but maybe a simple heuristic to clean up could be keep track of the current local storage key. If the key gets changed (because the inputs change) we could just delete the current key, before setting current key to the new key
  • I also like your idea of adding a UI option as this might be the more explicit solution
• I think localStorage is stored on hard drive, so maybe there's a minor performance gain in debouncing localStorage writes?
• I would like to brainstorm if there could be a simple heuristic of when to reset the cache key and when to keep the old one without things becoming too complex. Maybe we could also avoid resetting all values to their default by merging the contents of the previous local storage cache with the new local storage. This could maybe be done fairly simple (if nothing about the input was changed -> copy the old value, if something about the input was changed -> reset the value to default)

[runemadsen]

Nice! I think this is a good thing to implement if people are having problems with the localStorage state. I know that @bravomartin wants to take a look at the UI to try to make the inputs a bit smaller, since just a few inputs will now take up most of the sidebar. So perhaps let's have a quick discussion about this before that work starts?

[fdoflorenzano]

That makes sense! Yeah after Lucas' comments I did some research and indeed it doesn't seem as a very important issue at the moment. I guess it's mostly feeling there's potentially too much stuff left in localStorage haha

[lucasdinonolte]

Should this also take an optional argument so it can be used to delete a very specific local storage entry?

[fdoflorenzano]

✅

[lucasdinonolte]

Given that the mechanic_ prefix is used in multiple places now I think this should be a constant.

[fdoflorenzano]

✅

[netlify]

✅ Deploy Preview for dsi-logo-maker ready!

Name	Link
🔨 Latest commit	0ba3528
🔍 Latest deploy log	https://app.netlify.com/sites/dsi-logo-maker/deploys/632c744d959e960009806539
😎 Deploy Preview	https://deploy-preview-155--dsi-logo-maker.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.