Skip to content

feat(xaa): expose the read-only project-level audience on the XAA load response - #801

Merged
dorsha merged 1 commit into
mainfrom
feat/xaa-project-level-audience
Aug 26, 2026
Merged

feat(xaa): expose the read-only project-level audience on the XAA load response#801
dorsha merged 1 commit into
mainfrom
feat/xaa-project-level-audience

Conversation

@dorsha

@dorsha dorsha commented Aug 25, 2026

Copy link
Copy Markdown
Member

Related Issues

Required for:
https://github.com/descope/etc/issues/18013

Related PRs

Upstream PRs

Related PRs

In a Nutshell

  • Read-only audience on the XAA load response

Description

Loading Cross-App Access settings now also returns the audience a requesting application has to present in its ID-JAG token, so callers read the same value the console shows instead of building it themselves. It has no tenant in it - the identity provider sends the tenant in the token's aud_tenant claim.

Must

  • Tests
  • Documentation (if applicable)

…d response

loadXAASettings / loadAllXAASettings now surface the audience a requesting application
must present in its ID-JAG token, so callers read the same value the console and the
SSO setup suite show instead of building it by hand. It is project-level and names no
tenant - the IdP sends the tenant in the token's aud_tenant claim.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

🐕 Suggested Reviewers

This PR exposes a read-only audience field on the XAA load response, requiring changes to both test files and type definitions. We have two strong candidates with directly relevant expertise: one contributor has recent work on the test file being modified (sso.test.ts), and another has expertise in the types file being updated (types.ts). Both reviewers should be assigned to ensure comprehensive coverage of the changes across both the testing and type definition aspects of this feature.

Reviewer Reason
itaihanski Recent contributor to lib/management/sso.test.ts - can verify the test coverage for the new audience field exposure is adequate and follows existing test patterns
talaharoni Recent contributor to lib/management/types.ts - can validate that the new read-only audience type definition is correctly integrated and maintains type safety in the XAA load response structure

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

Adds a read-only audience field to XAASettingsResponse, which passes through untouched via the existing transformXAASettingsResponse and is covered by a test asserting the round-trip value.

Actionable comments posted: 0

Merge risk: 🟢 Low: additive optional field on the load response, no transform logic changes, correctly excluded from the write-side XAASettings type, and covered by a test.


Review scope: Full review

Reviewed files (2)
  • lib/management/sso.test.ts
  • lib/management/types.ts

@dorsha
dorsha merged commit d9252cb into main Aug 26, 2026
29 checks passed
@dorsha
dorsha deleted the feat/xaa-project-level-audience branch August 26, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants