feat(sso): allow disabling SAML AuthnRequest signing per SSO configuration - #842
Conversation
…ation Descope always signs the SAML AuthnRequest it sends to a tenant's IdP. A few IdPs (NetIQ Access Manager among them) reject a signed request outright when their trusted-provider entry holds no signing certificate for Descope, and until now there was no way to opt out. Adds DisableSignRequest to SSOSAMLSettings and SSOSAMLSettingsByMetadata, and exposes the stored value on SSOSAMLSettingsResponse. The flag is always sent on configure - the server treats the settings object as a full replacement, so omitting it on an update would silently turn signing back on. Defaults to false, so every existing configuration keeps signing as it does today. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThis SSO SAML feature PR requires reviewers with deep expertise across three key areas: (1) type definitions and API contracts, (2) SSO management logic implementation, and (3) test coverage. Selected reviewers span all modified files with complementary expertise: aviadl brings broad knowledge of the entire change scope including documentation, types, and management code; omercnet provides type system and documentation review; yosiharan ensures implementation and test quality for the core logic.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni Review
Adds a DisableSignRequest flag to SSOSAMLSettings/SSOSAMLSettingsByMetadata/SSOSAMLSettingsResponse so per-tenant SAML AuthnRequest signing can be opted out.
Actionable comments posted: 0
Merge risk: 🟢 Low: the flag is unconditionally included in the request map (matching the "full replacement" semantics described in the PR), the response struct is unmarshaled via standard JSON tags, and both toggle directions (true/false) are exercised in new tests.
Review scope: Full review
Reviewed files (4)
README.mddescope/internal/mgmt/sso.godescope/internal/mgmt/sso_test.godescope/types.go
|
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
Description
Issue: https://github.com/descope/etc/issues/18144
node-sdk: descope/node-sdk#805 · python-sdk: descope/python-sdk#1684
Descope signs the SAML
AuthnRequestit sends to a tenant's IdP. A few IdPs (NetIQ Access Manager among them) reject a signed request outright when their trusted-provider entry holds no signing certificate for Descope, and until now there was no way to opt out.This exposes the new per-SSO-configuration flag:
DisableSignRequestonSSOSAMLSettingsandSSOSAMLSettingsByMetadata.DisableSignRequestonSSOSAMLSettingsResponse, so the stored value is readable.The flag is always sent on configure, not omitted when false: the server treats the settings object as a full replacement, so omitting it on an update would silently turn signing back on.
Defaults to
false, so existing callers keep signing exactly as they do today.