docs: fix boundary wording for time-filter params and sync with main - #828
docs: fix boundary wording for time-filter params and sync with main#828dishanthirpara-maker wants to merge 12 commits into
Conversation
Co-authored-by: descope[bot] <107609351+descope[bot]@users.noreply.github.com>
* feat(mgmt): load external groups scoped to a specific SSO config Co-Authored-By: Claude <noreply@anthropic.com> * fix(mgmt): move ssoID to trailing param position per With* convention Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
…T on refresh (#815) The /v1/auth/sso/exchange response includes tenantSSOID (the id of the tenant SSO configuration that performed the authentication), which the SDK previously discarded — multi-SSO integrations need it to know which connection authenticated. It is now available on AuthenticationInfo. The /v1/auth/refresh response includes the rotated refresh JWT when refresh token rotation is enabled. The existing refresh methods return only the session token and surface the rotated token solely as a DSR cookie, which header-based backends cannot use. The new RefreshSessionInfoWithToken returns the full AuthenticationInfo, including the rotated refresh token that the internals already extracted but previously dropped. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Follow-up to #818: the backend resolves the identifier as either a login ID or a user ID (descope/backend#2092). Rename the parameter to loginIDOrUserID and update docs to match the SDK's dual-ID convention (Update, Delete, UpdateEmail). No wire change. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: descope-release-bot[bot] <139235589+descope-release-bot[bot]@users.noreply.github.com>
Co-authored-by: descope[bot] <107609351+descope[bot]@users.noreply.github.com>
Co-authored-by: descope[bot] <107609351+descope[bot]@users.noreply.github.com>
On both SSO applications, and third party apps + tests
#9538 What changed: - Corrected FromCreatedTime/FromModifiedTime doc comments in descope/types.go: "on or after" -> "after", to match confirmed backend behavior (SQL `>`, exclusive lower bound). - ToCreatedTime/ToModifiedTime already said "on or before" correctly (SQL `<=`, inclusive upper bound) - left unchanged. Verified: - Backend behavior confirmed directly in source across 3 repos in an earlier research pass: managementservice/internal/services/user.go (only the to* variants set Negative: true), common's search domain (negative flag selects Operator vs NegativeOperator), and userservice/internal/entities/search.go (Operator: " > ", NegativeOperator: " <= " for both createdtime and modifiedtime). - Comment-only change; no functional code touched. Not verified: - No integration/functional testing against a live Descope API was performed; this is a documentation wording fix only. - Branch was NOT updated from main (still BEHIND) per explicit decision: this repo's branch protection forbids merge commits, and reconciling via rebase would have required a force-push, which was out of scope for this fix.
Co-authored-by: descope[bot] <107609351+descope[bot]@users.noreply.github.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThis PR primarily addresses documentation fixes for time-filter parameter boundary wording (FromCreatedTime/FromModifiedTime) plus a merge with main branch. The core changes span auth module, management modules (user, group, ssoapplication, third_party_application), and infrastructure files. Selected reviewers provide comprehensive coverage: dorsha for overall architecture and breadth; aviadl for auth and core API changes; guyp-descope for management/SSO expertise; shilgapira for mgmt/group specific knowledge; and itaihanski for test coverage and cross-module validation. This ensures both the documentation accuracy and the merged code changes are properly vetted across all affected areas.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
This PR fixes the FromCreatedTime/FromModifiedTime doc comments (removing "on or") to correctly describe the backend's exclusive lower bound, and syncs the branch with main. The wording change is a pure comment fix, consistent with the sibling To*Time comments, and matches the actual pass-through in descope/internal/mgmt/user.go (no logic touched). The remaining diff bulk is content already merged/released via main (v1.29.0), not new work from this PR.
No actionable issues found. Good bones — clean, minimal, and correctly scoped. Woof!
Declared coverage: FULL — 23/23 changed files reviewed.
3 participants
Fixes wording in FromCreatedTime/FromModifiedTime doc comments to correctly reflect that these bounds are exclusive (strictly after), not inclusive (on or before), matching the backend's actual SQL comparison operators. Same fix already applied to descope-php, descope-ruby-sdk, and node-sdk in this PR series.
Also merges in the latest main, since this branch had fallen behind and direct updates are blocked by branch protection.
Merging into feature/9538-search-user-time-params directly is blocked by branch protection requiring PR-mediated changes, hence this small PR targeting the feature branch rather than main.