Skip to content

fix: make release-please tags Packagist-compatible - #140

Merged
dorsha merged 2 commits into
mainfrom
fix/release-please-packagist-tags
Aug 28, 2026
Merged

fix: make release-please tags Packagist-compatible#140
dorsha merged 2 commits into
mainfrom
fix/release-please-packagist-tags

Conversation

@dorsha

@dorsha dorsha commented Aug 28, 2026

Copy link
Copy Markdown
Member

Problem

Packagist has not picked up any release since the repo switched to release-please. Latest on Packagist is the manually created 0.7.0 tag (2026-07-30), while release-please's latest release descope-php-v0.6.6 (2026-08-28) never published.

Root cause: in manifest mode with package-name set, release-please defaults to include-component-in-tag: true, producing tags like descope-php-v0.6.6. Packagist only recognizes tags that parse as versions (X.Y.Z / vX.Y.Z), so it ignores these tags entirely — the "Update Packagist" API call in the workflow fires, Packagist crawls the repo, finds no new parseable tag, and publishes nothing. The plain tags it does have (0.6.4, 0.6.5, 0.7.0) were created manually to compensate.

Changes

  • release-please-config.json: add "include-component-in-tag": false so future releases are tagged vX.Y.Z.
  • .release-please-manifest.json: bump 0.6.6 -> 0.7.0 to acknowledge the manual 0.7.0 tag; otherwise the next release (0.6.7) would sort below the version Packagist already serves and composer would keep resolving 0.7.0 as latest.
  • composer.json: fix homepage to point at this repo instead of descope/php-sdk.

After merging

release-please will open a release PR for v0.7.1, covering everything since the manual 0.7.0 tag (including the descope-php-v0.6.6 content that never reached Packagist). Merging that release PR tags v0.7.1 and the existing workflow's Packagist update step will finally take effect.

🤖 Generated with Claude Code

release-please was tagging releases as descope-php-vX.Y.Z (component
prefix included by default in manifest mode). Packagist only recognizes
tags that parse as versions (X.Y.Z or vX.Y.Z), so every release since
the switch to release-please was invisible to Packagist and never
published. The manually created plain tags (0.6.4, 0.6.5, 0.7.0) are
the only versions Packagist has.

- Set include-component-in-tag: false so releases are tagged vX.Y.Z.
- Bump the manifest to 0.7.0 to acknowledge the manual 0.7.0 tag, so
  the next release sorts above the latest version already on Packagist.
- Fix composer.json homepage to point at this repo.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🐕 Suggested Reviewers

This PR fixes release process configuration to make tags Packagist-compatible by adjusting release-please settings. The changes span release automation configuration files and package metadata. Since there are only 2 candidates available and this PR touches core release infrastructure, we recommend reviewer index 0 who has broad coverage across all changed files and deep familiarity with the release-please configuration.

Reviewer Reason
omercnet Primary reviewer: omercnet has 4 commits across all 3 changed files (.release-please-manifest.json, composer.json, release-please-config.json), making them the most qualified to review the release-please configuration changes and assess Packagist compatibility implications.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

Config-only fix so release-please tags plain vX.Y.Z (Packagist-compatible) and aligns the manifest with the manually-tagged 0.7.0.

Actionable comments posted: 1

  • 1 🟡 Minor: manifest version bump not mirrored in the SDK_VERSION extra-file, causing a temporary version-header drift

Merge risk: 🟢 Low: config-only change with a clear, verifiable root cause and no code paths affected.

See inline comments for details.


Review scope: Full review

Reviewed files (3)
  • .release-please-manifest.json
  • composer.json
  • release-please-config.json

Comment thread .release-please-manifest.json
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

No new issues found.


Review scope: Incremental re-review

Reviewed new changes (1)
  • src/SDK/EndpointsV1.php
Previously reviewed and unchanged: 3 files.

@dorsha
dorsha merged commit 0c32381 into main Aug 28, 2026
16 checks passed
@dorsha
dorsha deleted the fix/release-please-packagist-tags branch August 28, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant