fix: make release-please tags Packagist-compatible - #140
Conversation
release-please was tagging releases as descope-php-vX.Y.Z (component prefix included by default in manifest mode). Packagist only recognizes tags that parse as versions (X.Y.Z or vX.Y.Z), so every release since the switch to release-please was invisible to Packagist and never published. The manually created plain tags (0.6.4, 0.6.5, 0.7.0) are the only versions Packagist has. - Set include-component-in-tag: false so releases are tagged vX.Y.Z. - Bump the manifest to 0.7.0 to acknowledge the manual 0.7.0 tag, so the next release sorts above the latest version already on Packagist. - Fix composer.json homepage to point at this repo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThis PR fixes release process configuration to make tags Packagist-compatible by adjusting release-please settings. The changes span release automation configuration files and package metadata. Since there are only 2 candidates available and this PR touches core release infrastructure, we recommend reviewer index 0 who has broad coverage across all changed files and deep familiarity with the release-please configuration.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni Review
Config-only fix so release-please tags plain vX.Y.Z (Packagist-compatible) and aligns the manifest with the manually-tagged 0.7.0.
Actionable comments posted: 1
- 1 🟡 Minor: manifest version bump not mirrored in the
SDK_VERSIONextra-file, causing a temporary version-header drift
Merge risk: 🟢 Low: config-only change with a clear, verifiable root cause and no code paths affected.
See inline comments for details.
Review scope: Full review
Reviewed files (3)
.release-please-manifest.jsoncomposer.jsonrelease-please-config.json
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
Problem
Packagist has not picked up any release since the repo switched to release-please. Latest on Packagist is the manually created
0.7.0tag (2026-07-30), while release-please's latest releasedescope-php-v0.6.6(2026-08-28) never published.Root cause: in manifest mode with
package-nameset, release-please defaults toinclude-component-in-tag: true, producing tags likedescope-php-v0.6.6. Packagist only recognizes tags that parse as versions (X.Y.Z/vX.Y.Z), so it ignores these tags entirely — the "Update Packagist" API call in the workflow fires, Packagist crawls the repo, finds no new parseable tag, and publishes nothing. The plain tags it does have (0.6.4,0.6.5,0.7.0) were created manually to compensate.Changes
release-please-config.json: add"include-component-in-tag": falseso future releases are taggedvX.Y.Z..release-please-manifest.json: bump0.6.6->0.7.0to acknowledge the manual0.7.0tag; otherwise the next release (0.6.7) would sort below the version Packagist already serves and composer would keep resolving 0.7.0 as latest.composer.json: fixhomepageto point at this repo instead ofdescope/php-sdk.After merging
release-please will open a release PR for
v0.7.1, covering everything since the manual0.7.0tag (including thedescope-php-v0.6.6content that never reached Packagist). Merging that release PR tagsv0.7.1and the existing workflow's Packagist update step will finally take effect.🤖 Generated with Claude Code