DEP-300 refactor : 사용자 정보를 수정하는 api endpoints 통합 - #78
Open
saint6839 wants to merge 4 commits into
Open
Conversation
saint6839
requested review from
gojung and
junhaesung
and removed request for
gojung
December 27, 2022 13:35
Contributor
Author
|
클라분들 요청에 따라, 추후에 반영될 예정입니다. |
junhaesung
requested changes
Jan 23, 2023
junhaesung
left a comment
junhaesung
left a comment
Member
There was a problem hiding this comment.
하위호환 유지하려면 v1 api 삭제하시면 안됩니다.
삭제하신 api 들 다시 살려주시고, deprecated 정도로만 표시해주세요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💁♂️ PR 내용
/api/v1/members/name
/api/v1/members/consents
/api/v1/members/resources
위 endpoint들을 하나의 endpoint로 통합하였습니다.
🙏 작업
[AS-IS]
이름, 알림여부 설정, resource 수정 api가 각각 하나씩 3개의 api로 분리되어 있었음
[TO-BE]
PATCH
/api/v1/members/me라는 하나의 api로 관리되어지도록 수정🤖 테스트 체크리스트