tighten action tests

[atkrad]

Summary

• Cover caller-visible gaps in deploy, delete, list, and status: cancellation, wrapped dependency errors, the Helm label query, wildcard release filtering, and invalid filters.
• Check dry-run and environment identity on deploy, and project, environment, and wait forwarding on delete.
• Follow the testing principles for failure paths, ErrorIs and ErrorContains, t.Parallel, per-test fakes, and assertions on returned values.

DeleteParams.DryRun and DeleteParams.Wait are unused by Check and Execute, so those fields have no behavior to lock. A deadline is the same forwarded context error as cancellation.

Related

Test plan

• Unit tests added/updated
• Scenario under scenarios/ (if behavior changes)
• nix run .#lint / pre-commit clean
• Manual smoke (command + expected result), if user-facing

go test -count=3 -race -shuffle=on ./internal/action/ passed. Pre-commit, including golangci-lint, passed on the commit.

Labels

• One of: kind/feature, kind/bug, kind/docs, kind/chore
• Add breaking-change if this breaks existing CLI or config behavior
• Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

• Title is short and imperative (matches commit style)
• Docs / CLI help updated when user-facing (README.md, docs/cli/)
• No secrets or local-only paths in the diff

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!