Repository navigation
rewrite e2e scenarios as yaml steps - #184
Merged
Merged
Conversation
- move the kind suite under internal/testing/e2e - check fixtures with an embedded json schema before they run - delete only namespaces this run created
atkrad
added
kind/chore
github-actions
Bot
added
kind/docs
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
- stop later assertions after a terminal failure - delete namespaces and CRDs only with a recorded uid - move the Kind suite out of the runner and drop image preload
- run scenarios with plain subtests and one shared cluster - delete that cluster even when setup stops early - include the observed value when a comparison is false
- create clients before the namespace claim and register cleanup next - keep the comparison operator in cel failure text - show assertion failures on the test case itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/testing/e2eand run scenarios from the new six-step YAML.Related
Test plan
scenarios/(if behavior changes)nix run .#lint/ pre-commit cleango test ./internal/testing/ ./internal/testing/e2e/ ./internal/testing/celassert/passed.go test -tags integration ./internal/testing/passed.DEPLOYAH_E2E_FORCE=1 nix run .#test-e2epassed (64 tests).Labels
kind/feature,kind/bug,kind/docs,kind/chorebreaking-changeif this breaks existing CLI or config behaviorskip-changelogfor internal-only PRs that should not appear in notesChecklist
README.md,docs/cli/)