Skip to content

run e2e scenarios from a private copy - #183

Merged
atkrad merged 1 commit into
mainfrom
isolate-e2e-workspaces
Oct 9, 2026
Merged

atkrad merged 1 commit into
mainfrom
isolate-e2e-workspaces

Conversation

@atkrad

@atkrad atkrad commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Each E2E scenario runs from its own temporary copy of the scenario directory, so a test does not write into the tracked files under scenarios/.
  • The copy is made before the Kubernetes namespace is created. A symbolic link in the source is rejected, so a later open cannot leave the copy.
  • The old copyTree helper is gone. The integration suite is unchanged.

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing

Also ran go test ./internal/testing/... -race -count=1, go test ./... -race -count=1, and DEPLOYAH_E2E_FORCE=1 nix run .#test-e2e (46 tests). scenarios/ was unchanged after the Kind run.

Labels

  • One of: kind/feature, kind/bug, kind/docs, kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

- copy each scenario into a temp dir before creating a namespace
- reject symbolic links so a later open stays inside the copy
- replace the e2e copyTree helper with that copy
@atkrad atkrad added kind/chore Cleanup, deps, CI, or refactor with no user-facing change skip-changelog Exclude this PR from release notes area/testing Scenarios, harness, goldens labels Oct 9, 2026
@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/testing/workspace.go 92.30% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@atkrad
atkrad merged commit b29c9d9 into main Oct 9, 2026
17 checks passed
@atkrad
atkrad deleted the isolate-e2e-workspaces branch October 9, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing Scenarios, harness, goldens kind/chore Cleanup, deps, CI, or refactor with no user-facing change skip-changelog Exclude this PR from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant