Repository navigation
build semantic plans in one constructor - #180
Merged
Merged
Conversation
- derive WillRun inside semantic.New - remove stamp and attach helpers - drop view task-graph checks
atkrad
added
kind/chore
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- state package boundaries instead of the build steps - call semantic.New directly in drift and chart CRD tests - drop leftover historical view assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semantic.Newis the only constructor. It copies the input, checks shape, and setsWillRunfrom the Helm action.BuildSemanticPlancalls that constructor once, with changes, tasks, drift, and chart CRDs.stampTaskWillRun,AttachDrift, andAttachChartCRDsare gone.Test plan
nix run .#lintand pre-commitgofmtcleango test ./internal/plan/... -count=1andgo test -race ./internal/plan/... -count=1nix run .#test-unitgo test ./internal/plan/view -update -count=1leftinternal/plan/view/testdata/goldenunchangedLabels
kind/feature,kind/bug,kind/docs,kind/choreskip-changelogfor internal-only PRs that should not appear in notesChecklist
README.md,docs/cli/)