Skip to content

simplify plan view tests - #179

Merged
atkrad merged 1 commit into
mainfrom
simplify-plan-view-tests
Oct 6, 2026
Merged

atkrad merged 1 commit into
mainfrom
simplify-plan-view-tests

Conversation

@atkrad

@atkrad atkrad commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Give each plan view golden one owning test, and drop checks that repeat the snapshot.
  • Move the empty-plan and tasks JSON documents into golden files.
  • Rename style role traces to human_<scenario>.roles.golden.

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing

Labels

  • One of: kind/feature, kind/bug, kind/docs, kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

- keep one owner for each golden file
- move full json documents into goldens
- rename style role traces to human names
@atkrad atkrad added kind/chore Cleanup, deps, CI, or refactor with no user-facing change skip-changelog Exclude this PR from release notes labels Oct 6, 2026
@github-actions github-actions Bot added the area/deploy Deploy and plan session flow label Oct 6, 2026
@atkrad
atkrad merged commit 8624792 into main Oct 6, 2026
16 checks passed
@atkrad
atkrad deleted the simplify-plan-view-tests branch October 6, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deploy Deploy and plan session flow kind/chore Cleanup, deps, CI, or refactor with no user-facing change skip-changelog Exclude this PR from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant