Repository navigation
remove offline planning - #161
Merged
Merged
Conversation
- drop deployah plan --offline and RenderOffline - render test fixtures without a production API - keep plan cluster-aware
github-actions
Bot
added
kind/docs
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- render scenario fixtures from internal/testing - keep the semantic render local to the view tests - remove the deleted-flag test and fix the TLS comment
atkrad
added
kind/chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployah planis always cluster-aware.--offlineis an unknown flag, with no alias or hidden flag.RenderOfflineAPI andCountResources. Tests render fixture charts through test helpers instead.deployah validateanddeployah resolve.Related
Test plan
scenarios/(if behavior changes)nix run .#lint/ pre-commit cleandeployah plan --helphas no--offline.deployah plan prod --offlinefails withunknown flag: --offlinebefore cluster work.go test -race ./..., integration tests,gen-docs, markdown lint, and link checks passed. Scenario goldens did not change.Labels
kind/feature,kind/bug,kind/docs,kind/chorebreaking-changeif this breaks existing CLI or config behaviorskip-changelogfor internal-only PRs that should not appear in notesChecklist
README.md,docs/cli/)