Repository navigation
always run helm on deploy - #160
Merged
Merged
Conversation
- drop the plan preview, confirmation, and no-op gate - render only before a volume resize - keep semantic HelmAction as a plan result
atkrad
added
kind/feature
github-actions
Bot
added
kind/docs
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- keep accepted ADRs as the current architecture - expect Deployed from a second unchanged deploy - mention the resize render in RenderResult docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployah deployvalidates the spec, runs guards, then always runs Helm: an install for a new release, an upgrade for an existing one--yes,--reapply, and the no-op gate are gone; a chart render happens only before a volume resizeRelated
Test plan
scenarios/(if behavior changes)nix run .#lint/ pre-commit cleango test -race ./...,golangci-lint run ./..., taggedgo vetfor e2e and integration, andnix run .#test-integrationpassed. Kind e2e was not run becausekindis not installed on this machine.Labels
kind/feature,kind/bug,kind/docs,kind/chorebreaking-changeif this breaks existing CLI or config behaviorskip-changelogfor internal-only PRs that should not appear in notesChecklist
README.md,docs/cli/)