Skip to content

remove replace and plan completeness - #157

Merged
atkrad merged 1 commit into
mainfrom
remove-replace-and-completeness
Sep 24, 2026
Merged

atkrad merged 1 commit into
mainfrom
remove-replace-and-completeness

Conversation

@atkrad

@atkrad atkrad commented Sep 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove the resource-level Replace action and plan Completeness from the semantic model.
  • Human and JSON plan output no longer include a replace count or a completeness status.
  • The v1 schema keeps the same id and rejects those fields.

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing

Labels

  • One of: kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

- drop replace and completeness from the semantic model
- stop human and json output from describing a prediction
- reject the removed fields in the existing v1 schema
@github-actions github-actions Bot added the area/deploy Deploy and plan session flow label Sep 24, 2026
@atkrad atkrad self-assigned this Sep 24, 2026
@atkrad atkrad added kind/chore Cleanup, deps, CI, or refactor with no user-facing change breaking-change Breaking change; call out in release notes labels Sep 24, 2026
@atkrad
atkrad merged commit 27d7670 into main Sep 24, 2026
16 checks passed
@atkrad
atkrad deleted the remove-replace-and-completeness branch September 24, 2026 15:04
@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/plan/semantic/types.go 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deploy Deploy and plan session flow breaking-change Breaking change; call out in release notes kind/chore Cleanup, deps, CI, or refactor with no user-facing change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant