Build dist for all npm dependency updates - #741
Merged
Conversation
honeyankit
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild the checked-in action bundle for every npm Dependabot update, including indirect dependencies and development build tooling.
The existing workflow only runs for
direct:productionupdates. That misses updates such asundiciin #734, even though the transitive dependency is included indist/index.js. Dependency classification is not a reliable proxy for bundle impact; development tooling such as esbuild can also change generated output.The workflow now uses the build output as the selector:
npm_and_yarnDependabot PR.dist/directory.dist/is unchanged.The explicit staged-diff check also avoids suppressing genuine
git commiterrors withgit commit ... || exit 0.This matches the approach used by
github/dependabot-action.Validation:
mainproduces no staged change and takes the no-op path.dist/index.jschange and takes the commit path.npm run typechecknpm run lintgit diff --check