Fixes typo and emphasizes the role of the V8_FROM_SOURCE env var - #2013
Open
gabrielfalcao wants to merge 1 commit into
Open
Fixes typo and emphasizes the role of the V8_FROM_SOURCE env var#2013gabrielfalcao wants to merge 1 commit into
gabrielfalcao wants to merge 1 commit into
Conversation
|
|
Member
|
Thanks can you sign the CLA and run formatting so we can merge it? |
Author
I just signed. |
Author
|
Hey folks, just as FYI, I already signed the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
I was building rusty_v8 from scratch, ran into issues, sook help in the readme and got a bit confused about the role of the V8_FROM_SOURCE because of what appears to be a typo. I made a small change to address the confusing statement. I hope this helps the next one doing the same thing.