Skip to content

feat: allow overrides of inputs of projects that don't use flake.lock - #15

Merged
vic merged 3 commits into
denful:mainfrom
jbgi:with-inputs-inputs-overrides
Sep 1, 2026
Merged

feat: allow overrides of inputs of projects that don't use flake.lock#15
vic merged 3 commits into
denful:mainfrom
jbgi:with-inputs-inputs-overrides

Conversation

@jbgi

@jbgi jbgi commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

as well as following their inputs.
This override feature for dependencies with empty flake inputs is only effective when a dependency use the following (or functionally similar) pattern:

#default.nix
{
  inputsOverrides ? { },
}:
let
  withInputs = import ./with-inputs.nix [ ./follows.nix inputsOverrides ];
in
withInputs ./outputs.nix

and

#flake.nix
{ outputs = inputs: import ./. { inputsOverrides = removeAttrs inputs [ "self" ]; }; }

This patch also add the additional capability of following/accessing inputs of dependencies that does not use flake inputs put still provides a non empty inputs in their outputs (such as projects using with-inputs).

@jbgi
jbgi force-pushed the with-inputs-inputs-overrides branch from 041199e to 3313834 Compare August 3, 2026 07:10
@jbgi
jbgi marked this pull request as draft August 3, 2026 08:02
@jbgi
jbgi force-pushed the with-inputs-inputs-overrides branch from 3313834 to 15650f1 Compare August 3, 2026 08:50
@jbgi
jbgi marked this pull request as ready for review August 3, 2026 08:58
@jbgi
jbgi force-pushed the with-inputs-inputs-overrides branch from 15650f1 to ff30329 Compare August 3, 2026 11:53
@jbgi jbgi changed the title feat: allow overrides of inputs of with-inputs-based project feat: allow overrides of inputs of projects that don't use flake.lock Aug 5, 2026
@jbgi
jbgi marked this pull request as draft August 5, 2026 16:11
@jbgi
jbgi force-pushed the with-inputs-inputs-overrides branch 2 times, most recently from 55c906e to b3a35c4 Compare August 5, 2026 19:24
@jbgi
jbgi marked this pull request as ready for review August 5, 2026 19:25
@jbgi
jbgi force-pushed the with-inputs-inputs-overrides branch 5 times, most recently from 2bc0a0d to fbc8125 Compare August 11, 2026 14:29
@jbgi
jbgi force-pushed the with-inputs-inputs-overrides branch from fbc8125 to 9e9e47f Compare August 13, 2026 07:31

@vic vic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, can you please fix the CI error by running that command locally ?

with lon 1.0.0, ran
````
cd template/lon
rm lon.nix
lon init
lon update
````
@jbgi
jbgi requested a review from vic September 1, 2026 09:30
@vic
vic merged commit 21ff443 into denful:main Sep 1, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants