Support async calls to rdma_get_cm_event#1
Open
akshayknarayan wants to merge 2 commits into
Open
Conversation
Having a `async_cm_events` function that consumed self caused the drop handler to be called, which destroyed the connection state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, calls to
rdma_get_cm_eventuse the default blocking behavior (and as far as I can tell,rdma_get_cm_eventis the only blocking call in the library). This makes them somewhat hard to call from async contexts (have to start a thread, etc).Conveniently,
rdma_get_cm_eventgives us a fd that we can setO_NONBLOCKINGon, and then even more conveniently instead of having to poll that fd ourselves, tokio provides a way to hook into the epoll calls it's already making, viaAsyncFd.