fix: use component images to include image archives - #123
Open
brandtkeller wants to merge 1 commit into
Open
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Contributor
|
@brandtkeller it is insufficient to fix the issue, right? |
Member
Author
|
ah! I had made some assumptions but this is using the images references from the package to scan them external to the package. Now that I actually read what is happening there might be more we need to evaluate. I need to grab some context on how the scanning is typically performed.. is it against a built package or solely the zarf manifest? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the image selection process from using static
imagesto the ZarfComponentGetImages()method to mirror how upstream collects images (includingimageArchives)