Skip to content

fix: use component images to include image archives - #123

Open
brandtkeller wants to merge 1 commit into
mainfrom
hotfix_component_images
Open

fix: use component images to include image archives#123
brandtkeller wants to merge 1 commit into
mainfrom
hotfix_component_images

Conversation

@brandtkeller

Copy link
Copy Markdown
Member

Description

This updates the image selection process from using static images to the ZarfComponent GetImages() method to mirror how upstream collects images (including imageArchives)

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller
brandtkeller requested a review from a team as a code owner September 3, 2026 17:30
@michalszynkiewicz

michalszynkiewicz commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@brandtkeller it is insufficient to fix the issue, right?
The image archive can have some arbitrary images inside (as I believe is in @willswire 's case) that even if listed under images as zarf.internal/... won't be meaningful for scanning. Or am I missing something?

@brandtkeller

Copy link
Copy Markdown
Member Author

ah! I had made some assumptions but this is using the images references from the package to scan them external to the package.

Now that I actually read what is happening there might be more we need to evaluate. I need to grab some context on how the scanning is typically performed.. is it against a built package or solely the zarf manifest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants