Skip to content

fix: search button not being type button - #495

Merged
eoghanriley merged 1 commit into
mainfrom
eoghanriley/fix-search-button
Sep 2, 2026
Merged

fix: search button not being type button#495
eoghanriley merged 1 commit into
mainfrom
eoghanriley/fix-search-button

Conversation

@eoghanriley

@eoghanriley eoghanriley commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Searching when also filtering for cli is broken currently on prod and all the open branches currently. This PR aims to fix it. This can be tested by searching with the CLI filter on the preview and compare with prod.

@eoghanriley
eoghanriley requested a review from a team as a code owner September 2, 2026 17:09
@netlify

netlify Bot commented Sep 2, 2026

Copy link
Copy Markdown

Deploy Preview for uds-product-docs ready!

Name Link
🔨 Latest commit 7cca6da
🔍 Latest deploy log https://app.netlify.com/projects/uds-product-docs/deploys/6a98583642186300084dbd0d
😎 Deploy Preview https://deploy-preview-495--uds-product-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR prevents dynamically created search filter buttons from implicitly submitting an enclosing form.

  • Explicitly sets each product filter button’s type to button.

Confidence Score: 5/5

The PR appears safe to merge.

The explicit button type preserves the filter click behavior while preventing unintended form submission, with no blocking or non-blocking defects identified.

Important Files Changed

Filename Overview
src/components/Search.astro Correctly marks dynamically created search filter controls as non-submit buttons; no actionable issues found.

Reviews (1): Last reviewed commit: "fix: search button not being type button" | Re-trigger Greptile

@eoghanriley
eoghanriley merged commit 19e9d1c into main Sep 2, 2026
9 checks passed
@eoghanriley
eoghanriley deleted the eoghanriley/fix-search-button branch September 2, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants