fix: search button not being type button - #495
Merged
Merged
Conversation
✅ Deploy Preview for uds-product-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Greptile SummaryThis PR prevents dynamically created search filter buttons from implicitly submitting an enclosing form.
Confidence Score: 5/5The PR appears safe to merge. The explicit button type preserves the filter click behavior while preventing unintended form submission, with no blocking or non-blocking defects identified. Important Files Changed
Reviews (1): Last reviewed commit: "fix: search button not being type button" | Re-trigger Greptile |
bradclawsie
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching when also filtering for cli is broken currently on prod and all the open branches currently. This PR aims to fix it. This can be tested by searching with the CLI filter on the preview and compare with prod.