feat(ci): uds cli next in ci and publish next demo bundles - #2941
feat(ci): uds cli next in ci and publish next demo bundles#2941joelmccoy wants to merge 13 commits into
Conversation
joelmccoy
changed the title
|
@greptileai @codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Greptile SummaryThe PR moves primary demo-bundle CI to UDS CLI Next while retaining Legacy compatibility and publication paths.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
S[Core package sources] --> L[Build functional layers]
L --> N[Create CLI Next bundles]
S --> G[Create Legacy bundles]
N --> T[Deploy and validate Next bundle]
G --> C[Legacy compatibility validation]
T --> P[Publish Next bundles]
C --> Q[Publish Legacy bundles]
Reviews (5): Last reviewed commit: "chore: more cleanup" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟡 Changes recommended
Critical versioning and artifact-resolution failures, plus unsafe value serialization and lost schema validation, remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Transitions demo bundle CI and publishing to UDS CLI Next while retaining Legacy compatibility.
Changes:
- Adds standard and slim CLI Next bundle definitions and configurations.
- Routes primary testing and deployment through CLI Next.
- Publishes Next artifacts alongside Legacy bundles and documents the migration.
File summaries
| File | Review |
|---|---|
test/playwright/private-pki/tasks.yaml |
Generates CLI Next PKI configuration. |
tasks/test.yaml |
Splits Next and Legacy test workflows. |
tasks/publish.yaml |
Critical: Default version targets unavailable 1.11.0 release artifacts. |
tasks/lint.yaml |
Moderate: Removes explicit values/schema validation without an equivalent check. |
tasks/deploy.yaml |
Critical: Regresses the default deployment version to 1.11.0. |
tasks/create.yaml |
Critical: Uses an unset VERSION when staging the generated artifact. |
tasks.yaml |
Exposes Next and Legacy test entry points. |
bundles/k3d-standard-next/values/core-runtime-security.yaml |
Templates runtime-security values. |
bundles/k3d-standard-next/values/core-monitoring.yaml |
Moderate: PostgreSQL password interpolation is not safely serialized. |
bundles/k3d-standard-next/values/core-logging.yaml |
Moderate: S3 secret-key interpolation is not safely serialized. |
bundles/k3d-standard-next/values/core-identity-authorization.yaml |
Moderate: Password interpolation is not safely serialized. |
bundles/k3d-standard-next/values/core-base.yaml |
Moderate: Classification-banner text is not safely serialized. |
bundles/k3d-standard-next/values/core-backup-restore.yaml |
Templates backup and restore values. |
bundles/k3d-standard-next/README.md |
Documents the standard Next bundle. |
bundles/k3d-standard-next/defaults.uds.hcl |
Defines standard bundle defaults. |
bundles/k3d-standard-next/config-upgrade.uds.hcl |
Configures upgrade testing. |
bundles/k3d-standard-next/config-test.uds.hcl |
Configures standard testing. |
bundles/k3d-standard-next/config-test-multi-node.uds.hcl |
Configures multi-node testing. |
bundles/k3d-standard-next/config-ha.uds.hcl |
Configures HA testing. |
bundles/k3d-standard-next/bundle.uds.hcl |
Critical: Local version 1.11.0 does not match generated 1.12.0 artifacts. |
bundles/k3d-standard-next/bundle-no-portal.uds.hcl |
Critical: Registry1/no-Portal sources do not match generated 1.12.0 artifacts. |
bundles/k3d-slim-dev-next/values/core-identity-authorization.yaml |
Moderate: Password interpolation is not safely serialized. |
bundles/k3d-slim-dev-next/values/core-base.yaml |
Templates slim base-layer values. |
bundles/k3d-slim-dev-next/README.md |
Documents the slim Next bundle. |
bundles/k3d-slim-dev-next/defaults.uds.hcl |
Defines slim bundle defaults. |
bundles/k3d-slim-dev-next/bundle.uds.hcl |
Critical: Local version 1.11.0 does not match generated 1.12.0 artifacts. |
adrs/0011-use-uds-cli-next-for-main-demo-bundle-ci.md |
Records the migration decision; one sentence-case heading nit remains. |
.yamllint |
Excludes generated and templated YAML. |
.github/workflows/test.yaml |
Removes direct values-equivalency testing. |
.github/workflows/test-cli-matrix.yaml |
Adds Next and Legacy compatibility cases. |
.github/workflows/pull-request-conditionals.yaml |
Removes values-test scheduling. |
.github/workflows/publish.yaml |
Critical: Next HCL versions are omitted from normal release-version updates. |
Review details
Suppressed comments (1)
adrs/0011-use-uds-cli-next-for-main-demo-bundle-ci.md:47
- NIT: Documentation headings use sentence case, so “Considered” should not be capitalized here.
## Alternatives Considered
- Files reviewed: 32/32 changed files
- Comments generated: 13
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a983e82a14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@greptileai @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b204d72ff3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8be6b6d98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🟡 Changes recommended
A critical release-signing issue and moderate CLI matrix coverage gap remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
tasks/create.yaml:179
- The slim Next bundle is also always created unsigned and then published at
tasks/publish.yaml:75-76. Registry consumers therefore cannot use normal signature verification and must bypass the trust check. Add a release-specific keyless signing mode while retaining--unsignedonly for local/test artifacts.
- Files reviewed: 37/37 changed files
- Comments generated: 2
- Review effort level: Balanced
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ead3a2034
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🟡 Changes recommended
CI trigger gaps and incomplete domain and Redis value propagation must be fixed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (2)
.github/workflows/test-cli-matrix.yaml:17
- This path filter excludes the task implementations that the matrix executes (
tasks/create.yaml,tasks/deploy.yaml, andtasks/test.yaml). A PR can therefore break the minimum-version or Legacy compatibility paths without running this workflow; include these task files in the trigger and keep the documented trigger list in sync.
paths:
- ".github/workflows/test-cli-matrix.yaml"
- "bundles/k3d-standard/**"
- "bundles/k3d-standard-next/**"
docs/concepts/platform/environments.mdx:20
- This now directs local-development users to the Next bundles, but the local demo deployment guide still only documents the Legacy
uds deploy k3d-core-demo:latestflow. Add or link to the requiredCLI_FEATURES=NextMode=true uds bundle deploy ...instructions so users can act on this recommendation.
> For local development, Defense Unicorns publishes Legacy and UDS CLI Next demo bundles. Use **`k3d-core-slim-dev`** or **`k3d-core-slim-dev-next`** for Base + Identity & Authorization, and use **`k3d-core-demo`** or **`k3d-core-demo-next`** for Full Core. All published demo bundles use the `upstream` flavor.
- Files reviewed: 40/40 changed files
- Comments generated: 3
- Review effort level: Balanced
|
@codex @greptileai review |
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved moderate issues can break Grafana scheduling and private-PKI certificate propagation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (4)
docs/concepts/platform/environments.mdx:20
- MAJOR: This now directs local-development users to the Next bundles, but the existing install guide still documents only
uds deploy k3d-core-demo:latest. That command does not enable Next mode, and these new artifacts are unsigned, so users also need the explicit signature-verification bypass and its security caveat. Updatedocs/getting-started/local-demo/install-and-deploy-uds.mdxwith a separate Next workflow before advertising these as usable options here.
> For local development, Defense Unicorns publishes Legacy and UDS CLI Next demo bundles. Use **`k3d-core-slim-dev`** or **`k3d-core-slim-dev-next`** for Base + Identity & Authorization, and use **`k3d-core-demo`** or **`k3d-core-demo-next`** for Full Core. All published demo bundles use the `upstream` flavor.
docs/dev/ci-testing.md:25
- MINOR: This relative link leaves the published docs tree and resolves to a non-existent
/bundles/...page on the documentation site. Link to the repository source URL instead, as this page already does for layer packages.
docs/dev/ci-testing.md:35 - MINOR: These relative links target files outside the published docs tree, so they become broken
/bundles/...links on the documentation site. Use repository source URLs for both bundle definitions.
docs/dev/ci-testing.md:68 - MINOR: These source-file links escape the published docs tree and resolve to non-existent
/bundles/...routes. Use GitHub source URLs for the Legacy and Next bundle files.
- Files reviewed: 41/41 changed files
- Comments generated: 2
- Review effort level: Balanced
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2da29f1faf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
688ea8b to
9ee7871
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ee78710d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f031757ff1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 714c030892
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chance-coleman
left a comment
chance-coleman
left a comment
There was a problem hiding this comment.
initial review, looks pretty solid.
Description
Updates UDS Core CI to use CLI Next:
Related Issue
Fixes CLI-223
Type of change
Steps to Validate
uds runChecklist before merging