Skip to content

chore: add module specific Zarf Helm releaseName - #3293

Open
AmberFryar wants to merge 7 commits into
mainfrom
add-module-specific-zarf-helm-release-name
Open

chore: add module specific Zarf Helm releaseName#3293
AmberFryar wants to merge 7 commits into
mainfrom
add-module-specific-zarf-helm-release-name

Conversation

@AmberFryar

@AmberFryar AmberFryar commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Description

UDS Dependency Operator also fails when its Pepr chart is deployed beside UDS Core.

Both UDS Core’s generated Pepr chart and Dependency Operator’s generated Pepr chart used name: module in the pepr-system namespace. When releaseName is unset, Zarf defaults the Helm release name to the chart name.

That caused both charts to resolve to the same Helm release, module. Deploying the Dependency Operator chart could therefore upgrade/replace UDS Core’s Pepr chart release and prune UDS Core’s Pepr admission and watcher resources.

Changes

  • Add a module-specific releaseName to generated Zarf chart metadata.
  • Keep chart name: module by default to preserve existing imports and Zarf values paths.
  • Use pepr-<uuid> as the default release name.
  • Preserve --custom-name behavior by using the custom name for the component name, chart name, and release name.
  • Update unit and integration expectations for the new generated chart contract.

...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@AmberFryar
AmberFryar requested a review from a team as a code owner August 26, 2026 23:39
@AmberFryar
AmberFryar marked this pull request as draft August 26, 2026 23:39
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.80%. Comparing base (eb70997) to head (e39508e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3293   +/-   ##
=======================================
  Coverage   77.79%   77.80%           
=======================================
  Files          92       92           
  Lines        2545     2546    +1     
  Branches      544      545    +1     
=======================================
+ Hits         1980     1981    +1     
  Misses        439      439           
  Partials      126      126           
Files with missing lines Coverage Δ
src/lib/assets/yaml/generateZarfYaml.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR assigns module-specific Helm release names to generated Zarf chart metadata while preserving the existing default chart name.

  • Uses pepr-<uuid> as the default release name.
  • Uses the custom build name for the component, chart, and release when provided.
  • Updates unit and integration expectations for the generated chart contract.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported integration expectation now includes the generated custom release name.

Important Files Changed

Filename Overview
src/lib/assets/yaml/generateZarfYaml.ts Adds a module-specific Helm release name to generated Zarf chart settings.
src/lib/assets/yaml/generateZarfYaml.test.ts Covers default and custom release-name generation.
integration/cli/build.nonconflict.test.ts Updates the chart integration expectation to include the custom release name.

Reviews (3): Last reviewed commit: "Merge branch 'main' into add-module-spec..." | Re-trigger Greptile

Comment thread src/lib/assets/yaml/generateZarfYaml.ts
@AmberFryar

Copy link
Copy Markdown
Contributor Author

@greptileai review

@AmberFryar
AmberFryar marked this pull request as ready for review September 3, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant