feat: add regex pattern field on inputs - #191
Draft
RothAndrew wants to merge 2 commits into
Draft
Conversation
Member
Author
|
First commit is just the tests TDD-style. Working on the PR now. Will drop another note if I need to set it down so somebody else can pick it up if they want to. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new field, pattern, for input validation using regex on input fields. It adds a new test task in the YAML file and updates the end-to-end tests to verify both valid and invalid regex inputs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/test/tasks/inputs/tasks-with-inputs.yaml | Added a test task "input-with-regex" with regex-based validations |
| src/test/e2e/runner_inputs_test.go | Added end-to-end tests for validating regex-based input behavior |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Putting this aside since there is resistance to the idea. Putting forth my vote to do this (and whatever else needs to be done so that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
patternfield for inputs, so that inputs can be checked against a regexRelated Issue
Relates to #190
Type of change
Checklist before merging