Skip to content

fix: if the input name has a dash the ${{ .inputs.input-name }} syntax doesn't work #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RothAndrew wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: if the input name has a dash the ${{ .inputs.input-name }} syntax doesn't work #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/test/e2e/runner_inputs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,4 +158,11 @@ func TestRunnerInputs(t *testing.T) {
require.NoError(t, err, stdOut, stdErr)
require.Contains(t, stdErr, "Input1Tmpl: input1 Input1Env: input1 Input2Tmpl: input2 Input2Env: input2 Input3Tmpl: notthedefault Input3Env: notthedefault Var: baz")
})

t.Run("test that verifies that dashes can be used in input names", func(t *testing.T) {
stdOut, stdErr, err := e2e.Maru("run", "with:dashes-in-input-names", "--file", "src/test/tasks/inputs/tasks.yaml", "--with", "required-input-with-dashes=foo")
require.NoError(t, err, stdOut, stdErr)
//require.Contains(t, stdErr, "foo bar foo bar foo bar foo bar")
require.Contains(t, stdErr, "foo bar foo bar foo bar")
})
}
13 changes: 13 additions & 0 deletions src/test/tasks/inputs/tasks-with-inputs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,16 @@ tasks:
actions:
- cmd: |
echo "Input1Tmpl: ${{ .inputs.input1 }} Input1Env: $INPUT_INPUT1 Input2Tmpl: ${{ .inputs.input2 }} Input2Env: ${INPUT_INPUT2} Input3Tmpl: ${{ .inputs.input3 }} Input3Env: $INPUT_INPUT3 Var: $FOO"

- name: dashes-in-input-names
description: Test task that puts dashes in input names
inputs:
required-input-with-dashes:
description: A required input with dashes in its name
required: true
default-input-with-dashes:
description: A default input with dashes in its name
default: bar
actions:
- cmd: |
echo "$INPUT_REQUIRED_INPUT_WITH_DASHES $INPUT_DEFAULT_INPUT_WITH_DASHES ${INPUT_REQUIRED_INPUT_WITH_DASHES} ${INPUT_DEFAULT_INPUT_WITH_DASHES} ${{ .inputs.required-input-with-dashes }} ${{ .inputs.default-input-with-dashes }} ${{ index .inputs "required-input-with-dashes" }} ${{ index .inputs "default-input-with-dashes" }}"