build: switch to trusted publishing - #2
Merged
Merged
Conversation
mpangrazzi
approved these changes
Apr 1, 2026
mpangrazzi
left a comment
mpangrazzi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Runner is already ubuntu-latest so we shouldn't have issues here 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to https://github.com/deepset-ai/haystack-private/issues/299
Proposed Changes:
Similar to deepset-ai/haystack#10976, this PR stops the pypi release workflow from using a secret token and instead uses trusted publishing.
How did you test it?
Tested similar changes with manually triggered pre-release in the haystack repository.
Notes for the reviewer
After reading https://docs.astral.sh/uv/guides/package/#updating-your-version I am not 100% sure if just using
uv publishwithout the token would work too. Using the github action is consistent with all other repos though, which is an advantage.Once this is merged, I will delete the GitHub action secret and revoke the token.