Skip to content

fix: use distinct critcmp group names so PR benchmark diff shows two columns #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepjoy merged 2 commits into from
Mar 22, 2026
Merged

fix: use distinct critcmp group names so PR benchmark diff shows two columns #77

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94c9772
fix: use distinct critcmp group names so PR benchmark diff shows two …
deepjoy Mar 22, 2026
9d34cd9
Merge branch 'main' into fix-benchmark-comparison-again
deepjoy Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ jobs:

- name: Cache baseline for PR comparison
if: github.event_name == 'push'
run: critcmp --export current > baseline.json
run: |
critcmp --export current > baseline.json
# Rename the group inside the JSON so critcmp can diff two distinct columns.
sed -i 's/"current"/"main"/' baseline.json

- name: Save baseline to cache
if: github.event_name == 'push'
Expand All @@ -90,7 +93,10 @@ jobs:
echo "::warning::No benchmark baseline found. Merge to main to generate one."
exit 0
fi
critcmp --export current > pr.json
critcmp --export current > pr-raw.json
# Rename so critcmp sees "pr" vs "main" as two distinct columns.
sed -i 's/"current"/"pr"/' pr-raw.json
mv pr-raw.json pr.json
echo 'result<<EOF' >> $GITHUB_OUTPUT
critcmp baseline.json pr.json >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
Expand Down
Loading