[codex] harden familiar mnesia recovery#21
Merged
Conversation
dcc827b to
39d929d
Compare
39d929d to
70ddf72
Compare
Owner
Author
|
Added one commit on top of this branch: 11d2e5b — Mnesia appends now prefer sync_transaction (data hits disk before the call returns), with a regression test that fails if the async path is ever used. Context: this PR's hardening (honest corruption errors + quarantine) plus that commit together close the crash-safety story from the 2026-07-05 cold-read finding (157-turn loom stranded by a corrupted LATEST.LOG). Full evidence trail: portfolio-audit-20260701/cold-reads/familiar.md and .tickets/dee-loom.md in the fleet repo. Verified independently: storage suite green, full suite 650 tests green. Merging this PR lands the whole fix. |
Same-repo PRs have secrets and no fork risk; the suite costs ~1min of Haiku. A gate belongs before the merge — post-merge red on main propagates into every branch cut from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.cantrip/mnesia/coresinstead of the repo rootRoot cause
A corrupt/truncated Mnesia transaction log can fatal during
previous_logdumping. Each retry wrote a fullMnesiaCore.*diagnostic file in the repo root, which amplified the disk-full failure mode.Validation
mix format --check-formatted lib/mix/tasks/cantrip.familiar.ex test/mix_cantrip_familiar_test.exsmix test test/mix_cantrip_familiar_test.exs --exclude mnesia_restartmix test test/mix_cantrip_familiar_test.exs --only mnesia_restart