Skip to content

release to prod #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avishkar58 merged 3 commits into from
Jul 12, 2026
Merged

release to prod #1370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98207a3
Merge pull request #1366 from deep-learning-indaba/develop
avishkar58 Jul 12, 2026
c9cbe92
Fix escaping of GCP private key
avishkar58 Jul 12, 2026
2e63e99
Merge pull request #1369 from deep-learning-indaba/develop
avishkar58 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,14 @@ jobs:
def scalar(value):
return "'" + str(value).replace("\\n", "\\\\n").replace("'", "''") + "'"

# GCP_PRIVATE_KEY is stored as a service-account JSON "private_key" value,
# i.e. already a single line with literal backslash-n sequences in place of
# real newlines. It must NOT go through scalar()'s newline-escaping, or the
# backslashes get escaped a second time and generator.py's single unescape
# leaves stray backslashes that break PEM parsing.
def preescaped_scalar(value):
return "'" + str(value).replace("'", "''") + "'"

with open("app.generated.yaml", "w") as f:
f.write("service: prod-api\n")
f.write("runtime: python311\n")
Expand All @@ -198,7 +206,8 @@ jobs:
f.write("\n")
f.write("env_variables:\n")
for key, value in env_variables.items():
f.write(" " + key + ": " + scalar(value) + "\n")
value_scalar = preescaped_scalar(value) if key == "GCP_PRIVATE_KEY" else scalar(value)
f.write(" " + key + ": " + value_scalar + "\n")
f.write("\n")
f.write("beta_settings:\n")
f.write(" cloud_sql_instances: " + scalar(os.environ["PROD_CLOUD_SQL_INSTANCE"]) + "\n")
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,14 @@ jobs:
def scalar(value):
return "'" + str(value).replace("\\n", "\\\\n").replace("'", "''") + "'"

# GCP_PRIVATE_KEY is stored as a service-account JSON "private_key" value,
# i.e. already a single line with literal backslash-n sequences in place of
# real newlines. It must NOT go through scalar()'s newline-escaping, or the
# backslashes get escaped a second time and generator.py's single unescape
# leaves stray backslashes that break PEM parsing.
def preescaped_scalar(value):
return "'" + str(value).replace("'", "''") + "'"

with open("app.generated.yaml", "w") as f:
f.write("service: staging-api\n")
f.write("runtime: python311\n")
Expand All @@ -201,7 +209,8 @@ jobs:
f.write("\n")
f.write("env_variables:\n")
for key, value in env_variables.items():
f.write(" " + key + ": " + scalar(value) + "\n")
value_scalar = preescaped_scalar(value) if key == "GCP_PRIVATE_KEY" else scalar(value)
f.write(" " + key + ": " + value_scalar + "\n")
f.write("\n")
f.write("beta_settings:\n")
f.write(" cloud_sql_instances: " + scalar(os.environ["STAGING_CLOUD_SQL_INSTANCE"]) + "\n")
Expand Down
Loading