Repository navigation
fix(coordinator): with the lower fee in force, the coordinator's own build must pay exactly that fee (#847) - #955
Merged
Merged
Conversation
…tly the builder's fee (#847) The guard of the coordinator's own build now requires fee_rule_for(target, in_force), a set of one, instead of every fee the era accepts. fee_marginals_permitted had no other caller and is removed with its test. The device is unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
…changelog entry (#847) The refusal of a 5,000 build where the lower fee is required names the remedy. The not-in-force test asserts the guard's own set and uses the boundary tip. The exact-fee wording moves into the existing B3b entry and fragment. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
… remedy is in the deploy notes (#847) Co-Authored-By: Claude <noreply@anthropic.com>
…d no longer reads it (#847) Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Part of the fee release (#847). When the lower network fee ZIP 2009 allows is in force for a vault's build, the coordinator's check of its own transaction now requires exactly the fee the builder's rule gives (1,000 per action), instead of either fee the era accepts. Before, a signer that ignored its permission and paid 5,000 would have passed silently, and the vault would have kept paying the higher fee and kept that mark on chain. When the lower fee is not in force, nothing changes: exactly 5,000.
This is a consistency check on the coordinator's own build, not a defence. The devices judge the fee they sign and, from block 3,590,000, accept either fee. With the switch at its default (ON) every vault still pays 5,000, so nothing a payment pays changes in this release.
orchestrator/src/fee.rs:guard_setreturnsfee_rule_for(target, zip2009_in_force(...)), a set of one, read with the same predicate and the same height as the signer.konclave-seal/src/epochs.rs:fee_marginals_permittedhas no caller left. It stays, with its doc rewritten in place, so the crate built into the device (and the committedui/src/wasm-pkg, which still reproduces byte for byte from source) is unchanged in this release. It is removed with the next device-package rebuild.deploy/helper/README.md: withper-vault, a send refused because the coordinator's own build paid 5,000 where the lower fee was required means the signer did not follow the permission; set the switch back to5000and restart.helper-server/CHANGELOG.mdand its fragment) says the guard requires the exact fee.Verify-before-finishing checklist
cargo fmt --check+cargo clippy -- -D warningspass (konclave-seal all features, orchestrator, helper-server)cargo test: konclave-seal, orchestrator (632), konclave-wasm (125) pass; helper-server 251 pass, 1 known timing flake (a_history_sync_and_a_funding_check_never_overlap_and_sync_once, fails on staging too)changelog.dandhelper-server/type(scope): descriptionCo-Authored-By: Claude <noreply@anthropic.com>. No session link.