Repository navigation
security(ui): harden how a device signs a payment it signed before - #952
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
…posal Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…nfirm it signed it Co-Authored-By: Claude <noreply@anthropic.com>
…ecord Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
… pinned Co-Authored-By: Claude <noreply@anthropic.com>
…r signature lives Co-Authored-By: Claude <noreply@anthropic.com>
… button Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
A device is more careful with a payment it already signed: it asks before signing a payment again in more cases, recognises the same payment when it comes back under another proposal (and quotes when it signed it, from its own record), shows an earlier transaction only when it can confirm it signed it, and proposals are signed only from their signing panel. The sign-again confirm also wraps on narrow screens, keeps focus when it closes by itself, and names its copy button.
Why one piece (over the 300-line guide)
It is one rule: whether a device may contribute a share to a payment it already signed. That rule spans the device's record, the owner's consent, the confirm screen and the standalone /net page. Splitting it would ship a state in which one of those contradicts the rule, which is exactly what the reviews of this change caught twice while it was built. More than half of the lines are tests.
Verify-before-finishing checklist
cargo fmt --check+cargo clippy -- -D warnings: not applicable (no Rust change)cargo test: not applicableui/: lint + vitest (264 files, 3061 tests) +tscpasstype(scope): descriptionCo-Authored-By: Claude <noreply@anthropic.com>, no session link