Repository navigation
build(pnpm): pin pnpm 10.34.9 so the supply-chain settings apply - #946
Merged
Merged
Conversation
pnpm-workspace.yaml sets minimumReleaseAge, trustPolicy: no-downgrade and blockExoticSubdeps, but package.json pinned pnpm@9.15.0, which ignores all three without a warning; pnpm reads them from 10.16, 10.21 and 10.26. packageManager now pins pnpm@10.34.9 (the newest 10.x at least 14 days old), and engines asks for pnpm >=10.26.0, so with engine-strict an older pnpm installed globally stops instead of skipping the checks. trustPolicyExclude lists the two locked packages the trust check refuses, each by exact version with its reason inline. The workflows' pnpm/action-setup steps set no version and read packageManager. The lockfile is unchanged; a frozen install on 10.34.9 reports it up to date and leaves it byte-identical. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 of 10 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
pnpm-workspace.yamlsetsminimumReleaseAge: 1440,trustPolicy: no-downgradeandblockExoticSubdeps: true, butpackage.jsonpinnedpnpm@9.15.0. pnpm 9 ignores all three without a warning. pnpm reads them from 10.16.0, 10.21.0 and 10.26.0 (trustPolicyExcludefrom 10.22.0; pnpm's own CHANGELOG). Measured on a copy of the repository: 9.15.0 accepted a TypeScript nightly published 19 hours earlier, and 10.34.9 refuses it.packageManageris nowpnpm@10.34.9, the newest 10.x at least 14 days old (2026-10-25;latest-10). 10.34.8 fixes hoisting when a frozen install removes packages and moves the standalone executables from Node 20 (end of life) to Node 24; 10.34.9 only affects a lockfile created from nothing. Neither changes the three keys.engines.pnpmis now>=10.26.0. Corepack switches to the pinned pnpm by itself, but a pnpm 9 installed globally kept running and skipped the checks. With the bound it stops withERR_PNPM_UNSUPPORTED_ENGINE(also withengine-strictoff).pnpm/action-setupsteps (ci.yml: ui, e2e, node-packages; desktop-release.yml) set noversionand readpackageManager. The actions stay pinned by SHA.trustPolicyExcludelists the only two locked packages the trust check refuses, each by exact version with its reason inline:semver@6.3.1(a backport; the check orders by publish date, a false positive) and@trickfilm400/rollup-plugin-off-main-thread@3.0.0-pre1(required byworkbox-build@7.4.1throughvite-plugin-pwa; its 2.5.0 carried provenance, 3.0.0-pre1 carries none: not evidence of compromise, worth a tarball diff). Removing either brings backERR_PNPM_TRUST_DOWNGRADEfor that package; a resolution from nothing finds no third.pnpm-lock.yamlis unchanged. A--frozen-lockfileinstall on 10.34.9 reports it up to date and leaves it byte-identical. The first resolving install under pnpm 10 (add/update) will addlibc:fields to the native-binding entries and dedupelru-cache11.5.2 into 11.5.3, once.changelog.d/changed/andchangelog.d/known-limits/.Known limit: the three settings act only when pnpm resolves dependencies. CI's
--frozen-lockfiledoes not resolve, so CI does not re-check an existing lockfile. They guard the moment a contributor changes it.Proofs (pnpm 10.34.9, Node 24)
minimumReleaseAge: add a TypeScript nightly 19 h oldERR_PNPM_NO_MATURE_MATCHING_VERSIONblockExoticSubdeps: a dependency whose own dependency is a git URL, or a tarballERR_PNPM_EXOTIC_SUBDEP; with the key off: DonetrustPolicy: exclusions removed, then a resolving addERR_PNPM_TRUST_DOWNGRADEERR_PNPM_UNSUPPORTED_ENGINEA tarball URL on
registry.npmjs.orgitself is not refused: pnpm counts the configured registry as trusted.To check on this PR
using pnpm v10.34.x. With the engines bound, a Vercel build on pnpm 9 now fails instead of skipping the keys.Supersedes #822 (same change, rebased onto today's staging, pin moved to 10.34.9, engines bound added). Closes #820.
Verify-before-finishing checklist
cargo fmt --check+cargo clippy -- -D warnings: not run, no Rust touchedcargo test: not run, no Rust touchedui/: lint (0 errors) + vitest (258 files, 2999 passed, 1 expected fail) + build (tsc + vite) pass on pnpm 10.34.9 / Node 24;sdkandmcp-server: tsc and vitest passtype(scope): descriptionCo-Authored-By: Claude <noreply@anthropic.com>, no session link