Repository navigation
docs: correct what we say about the padding limit, the I4 wording and the security email (#940, #941) - #944
Merged
Conversation
… the security email (#940, #941) ADR-0007 'I4 as built' says what waits for every seat and names the path of a device without every signature (#941). A Known limit says the device limits padding but not how many actions a payment carries, correcting two firmer sentences in 0.10.0 and 0.19.0 (#940). SECURITY.md lists security@deegalabs.com beside GitHub Security Advisories, with a note that no PGP key is published yet. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Three text corrections, no code change.
tseats (ADR-0012 D5). A correction note records the change.ui/changelog.d/known-limits/(The number of actions in a payment is not capped on the device #940). The device limits padding, but that limit grows with the transaction the coordinator builds, so a hostile or compromised coordinator can make the vault pay a higher fee than a payment needs. This corrects two firmer sentences in the 0.10.0 Known limits and the 0.19.0 entry for the lower network fee. Released sections are not rewritten.SECURITY.md: security@deegalabs.com as a second private channel beside GitHub Security Advisories, with a note that no PGP key is published yet, so the advisory form stays the better channel for exploit details. The same two channels are in https://www.deegalabs.com/.well-known/security.txt.Closes #941, Refs #940 (#940 stays open until the device-side bound ships).
Verify-before-finishing checklist
cargo fmt --check+cargo clippy -- -D warnings: not applicable (no Rust change)cargo test: not applicable (no Rust change)ui/: changelog tests (changelog-fragments,changelog-gate,changelog-sections,changelog-shape) pass; no UI source changedtype(scope): descriptionCo-Authored-By: Claude <noreply@anthropic.com>, no session link