Skip to content

docs: correct what we say about the padding limit, the I4 wording and the security email (#940, #941) - #944

Merged
danielgorgonha merged 1 commit into
stagingfrom
docs/known-limits-and-adr-0007
Nov 13, 2026
Merged

danielgorgonha merged 1 commit into
stagingfrom
docs/known-limits-and-adr-0007

Conversation

@danielgorgonha

Copy link
Copy Markdown
Member

What & why

Three text corrections, no code change.

  • ADR-0007, amendment "I4 as built", point 3 (ADR-0007 "I4 as built" says a vault is saved only when every seat finished; the device saves it earlier, as not finished #941). It said the vault is "registered, shown and saved only when every seat has". A device saves its record earlier, as not finished and with no address. The point now says what waits for every seat (the device's registration and the deposit address), names the path of a device that did not receive every signature (it finishes only on a vault pinned to its own key package), and notes that waiting for every seat is the app's rule, while the coordinator pins on t seats (ADR-0012 D5). A correction note records the change.
  • Known limit, ui/changelog.d/known-limits/ (The number of actions in a payment is not capped on the device #940). The device limits padding, but that limit grows with the transaction the coordinator builds, so a hostile or compromised coordinator can make the vault pay a higher fee than a payment needs. This corrects two firmer sentences in the 0.10.0 Known limits and the 0.19.0 entry for the lower network fee. Released sections are not rewritten.
  • SECURITY.md: security@deegalabs.com as a second private channel beside GitHub Security Advisories, with a note that no PGP key is published yet, so the advisory form stays the better channel for exploit details. The same two channels are in https://www.deegalabs.com/.well-known/security.txt.

Closes #941, Refs #940 (#940 stays open until the device-side bound ships).

Verify-before-finishing checklist

  • cargo fmt --check + cargo clippy -- -D warnings: not applicable (no Rust change)
  • cargo test: not applicable (no Rust change)
  • ui/: changelog tests (changelog-fragments, changelog-gate, changelog-sections, changelog-shape) pass; no UI source changed
  • No secret, key share, seed, or passphrase in code, logs, URLs, or query strings
  • Every fund-moving path keeps preview + explicit confirmation (no path touched)
  • FROST signer, PCZT, loopback bridge: not touched
  • User-facing strings: none added
  • Docs/comments in English; commit is type(scope): description
  • AI disclosure: written with Claude Code (drafting the three texts and running the changelog checks), reviewed by text and repo-rules audits; the commit carries Co-Authored-By: Claude <noreply@anthropic.com>, no session link

… the security email (#940, #941)

ADR-0007 'I4 as built' says what waits for every seat and names the path of a
device without every signature (#941). A Known limit says the device limits
padding but not how many actions a payment carries, correcting two firmer
sentences in 0.10.0 and 0.19.0 (#940). SECURITY.md lists security@deegalabs.com
beside GitHub Security Advisories, with a note that no PGP key is published yet.

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
konclave-demo Ready Ready Preview Nov 13, 2026 2:30am UTC

Request Review

@danielgorgonha danielgorgonha self-assigned this Nov 13, 2026
@danielgorgonha danielgorgonha added documentation Improvements or additions to documentation security Security / audit labels Nov 13, 2026
@danielgorgonha
danielgorgonha merged commit f20fef4 into staging Nov 13, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
Preview — 34b4fca5 Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation security Security / audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant