Cache parsed datasets instead of reopening per frame - #36
Merged
Conversation
Frames of the same dataset now share one parsed dataset object and one file mapping, published under a mutex and handed out as shared_ptr<const Dataset>. A cached entry whose file has grown is discarded before use, and read() refuses a chunk address outside the mapping. On a 5000-frame test set the frame loop drops from ~1250 ms to ~240 ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frames of the same dataset share one parsed dataset object and one file mapping. Includes a growth check so a cached entry is discarded if its file has been appended to, and a bound check on chunk addresses. Verified: full test suite green, clean under ThreadSanitizer, byte-identical output on all fixtures, unchanged exported symbols; frame-loop time on a 5000-frame set drops from ~1250 ms to ~240 ms.