Skip to content

Add TSan and Helgrind CI jobs #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxburian merged 1 commit into from
Aug 19, 2026
Merged

Add TSan and Helgrind CI jobs #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,56 @@ jobs:
${{github.workspace}}.build/src/dectris/neggia/plugin/dectris-neggia.so
if-no-files-found: error
retention-days: 90

# Concurrency gates. Flags go via env, NOT -DCMAKE_*_FLAGS — a -D would
# silently drop the gtest -Wno-error accommodation.
tsan:
runs-on: ubuntu-24.04
env:
CXXFLAGS: -fsanitize=thread -g -Wno-error=maybe-uninitialized
CFLAGS: -fsanitize=thread -g
TSAN_OPTIONS: halt_on_error=1
steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: true
- name: Create Build Directory
run: cmake -E make_directory ${{github.workspace}}.build
- name: Configure CMake (Release)
run: cmake ${{github.workspace}} -DCMAKE_BUILD_TYPE=Release -DDEBUG_PARSING=OFF -DCMAKE_POLICY_VERSION_MINIMUM=3.5
working-directory: ${{github.workspace}}.build
- name: Prove TSan instrumentation (fail if flags were lost)
run: grep -- '-fsanitize=thread' CMakeCache.txt
working-directory: ${{github.workspace}}.build
- name: Build
run: cmake --build .
working-directory: ${{github.workspace}}.build
- name: Test
run: ctest --output-on-failure
working-directory: ${{github.workspace}}.build

helgrind:
runs-on: ubuntu-24.04
env:
CXXFLAGS: -Wno-error=maybe-uninitialized
steps:
- name: Install valgrind
run: sudo apt-get update && sudo apt-get install -y valgrind
- name: Checkout
uses: actions/checkout@v4
with:
submodules: true
- name: Create Build Directory
run: cmake -E make_directory ${{github.workspace}}.build
- name: Configure CMake (Debug for symbolized Helgrind reports)
run: cmake ${{github.workspace}} -DCMAKE_BUILD_TYPE=Debug -DDEBUG_PARSING=OFF -DCMAKE_POLICY_VERSION_MINIMUM=3.5
working-directory: ${{github.workspace}}.build
- name: Build
run: cmake --build .
working-directory: ${{github.workspace}}.build
- name: Helgrind on concurrency tests (cwd = test dir for fixture symlink)
run: |
valgrind --tool=helgrind --error-exitcode=1 ./Test_XdsPluginConcurrent
valgrind --tool=helgrind --error-exitcode=1 ./Test_XdsPlugin
working-directory: ${{github.workspace}}.build/src/dectris/neggia/test
Loading