fix: update 3p-kubevirt for hotplug volume cleanup after migration target pod termination#2457
Open
yaroslavborbat wants to merge 6 commits into
Open
fix: update 3p-kubevirt for hotplug volume cleanup after migration target pod termination#2457yaroslavborbat wants to merge 6 commits into
yaroslavborbat wants to merge 6 commits into
Conversation
d691936 to
fad2e91
Compare
…rget pod termination Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
fad2e91 to
238d05b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
3p-kubevirtto include the fix for hotplug volume cleanup during migration target pod teardown.Why do we need it, and what problem does it solve?
In some migration flows the target pod may terminate before
virt-handlerstarts volume cleanup. In that case3p-kubevirtcould fail to create a cgroup manager and skipUnmountAll, leaving hotplug volume mounts behind.This update pulls in the upstream fix so cleanup still continues when the target pod is already gone.
What is the expected result?
After updating the artifact, hotplug volumes are unmounted even if the migration target pod has already terminated before cleanup starts.
Checklist
Changelog entries