fix: add missing DCL/Scene shader variants for WebGL#91
Open
dalkia wants to merge 1 commit into
Open
Conversation
Adds ALPHAPREMULTIPLY_ON with FOG_EXP and ALPHATEST_ON shadow caster variants that were reported missing in explorer WebGL builds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🔗 Merge Alignment ReminderIf this PR targets Both repos should be merged in coordination to avoid breaking changes. Do not merge one without the other being ready. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALPHAPREMULTIPLY_ON+FOG_EXPforward pass variants (passType 13) andALPHATEST_ONshadow caster variants (passType 8) toSceneVariants.shadervariants_GPU_INSTANCER_BATCHERand_SURFACE_TYPE_TRANSPARENTcompanion variants to match existing patternTest plan
🤖 Generated with Claude Code