feat: gate scene transactions by recipient in web3 confirmation popup#9486
Draft
alejandro-jimenez-dcl wants to merge 1 commit into
Draft
feat: gate scene transactions by recipient in web3 confirmation popup#9486alejandro-jimenez-dcl wants to merge 1 commit into
alejandro-jimenez-dcl wants to merge 1 commit into
Conversation
Decode the real recipient of a scene-initiated transaction (native transfer, ERC-20 transfer, or opaque contract call) and classify it into a trust gate shown to social-login users, who cannot review the raw transaction in an external wallet. - Resolve the recipient to a scene creator, a DCL profile, or an external wallet, checking scene creator before profile so creator sends show the creator gate rather than the generic profile gate. - Present the gate as a second confirmation after the initial transaction popup. - Recognize MANA across all known networks (mainnet/Goerli/Sepolia/ Polygon/Mumbai/Amoy) and render it as a sprite in the copy. - Add a debug-panel test-transaction tool; pass params as a JSON object so the dapp web-signer path can read the recipient. - Thread a cancellation token through the transaction confirmation flow.
Contributor
|
Build skipped — no changes detected under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode the real recipient of a scene-initiated transaction (native transfer, ERC-20 transfer, or opaque contract call) and classify it into a trust gate shown to social-login users, who cannot review the raw transaction in an external wallet.
Pull Request Description
What does this PR change?
Test Instructions
Steps (standard run):
metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Steps (fresh account):
metaforge account create --clear metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Automation (if applicable):
metaforge explorer test XXXXPrerequisites
Test Steps
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.