fix: adjustements on new loading screens#9481
Conversation
# Conflicts: # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipAction.prefab # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipAddFriends.prefab # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipEarnBadges.prefab # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipHangOut.prefab # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipLiveNow.prefab # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipMakeMove.prefab # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipSayHi.prefab # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipTakeShot.prefab # Explorer/Assets/DCL/SceneLoadingScreens/Assets/TipYourPeople.prefab
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
|
Tests: 24281 passed, 0 failed ✅ |
decentraland-bot
left a comment
There was a problem hiding this comment.
Review — PR #9481: fix: adjustments on new loading screens
STEP 2 — Root-cause check: ✅ PASS
This PR adjusts visual properties on loading screen tip prefabs to match Figma designs, following up on #9473. The changes directly address layout/visual polish — this is a direct fix, not treating a symptom.
STEP 3 — Design & integration: ✅ PASS (N/A)
No new code units, systems, managers, services, or lifecycle logic introduced. All changes are Unity prefab property overrides (positions, sizes, opacity, text, sprite references). No design evaluation needed.
STEP 4 — Member audit: ✅ PASS (N/A)
No public properties, accessors, or methods added or changed. Entirely prefab YAML.
STEP 5 — Line-level review: ✅ PASS
All changes are serialized Unity prefab YAML — no C# code to evaluate against CLAUDE.md rules. Verified the following are correct:
| Prefab | Change | Verified |
|---|---|---|
| TipAction | Background opacity 0.2 → 0.4, PixelsPerUnitMultiplier 1 → 1.3, cleaned float imprecision (0.000015258789 → 0) |
✅ |
| TipAddFriends | Fixed instruction text: "to see events" → "Add friend" (matches tip purpose), position adjustments |
✅ |
| TipEarnBadges | Vertical position offset (y: 3) |
✅ |
| TipHangOut | Position adjustment (y: -2), icon resized (42→50), vertical position overrides |
✅ |
| TipLiveNow | Vertical position offsets (y: 1, y: 1.56) |
✅ |
| TipMakeMove | Renamed TipMakeAMove → TipMakeMove, sprite swapped to new EmotesIcn (GUID 089798e4e628c4810949862aaf077ff0 matches new .meta), position adjustments |
✅ |
| TipSayHi | Vertical position adjustments (y: -1.92, y: 1) |
✅ |
| TipTakeShot | Horizontal position (x: 33) |
✅ |
| TipYourPeople | Vertical position, icon size (45×45), position overrides | ✅ |
| EmotesIcn.png | New 642-byte icon via LFS, import: mipmaps off, sprite mode, max 128px per platform, no compression — appropriate for a small UI icon | ✅ |
STEP 6 — Security review: ✅ PASS
No code, no APIs, no credentials, no user input handling, no network calls. Purely asset/prefab changes. No security concerns.
STEP 8 — Non-blocking warnings
None. Main.unity is not modified.
REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Prefab-only visual adjustments (positions, sizes, opacity, text, sprite references) with no C# code changes.
QA_REQUIRED: YES
Reviewed by Jarvis 🤖 · Requested by lorux0 via GitHub
What does this PR change?
Adjustements based on #9473
Test instructions
Check new loading screens are OK, either for new user or returning user.
https://www.figma.com/design/jjNmP9Z9pdw5fgg10Fg5W7/Product?node-id=5398-15586&t=6xn8Va3RDHcXkFUP-0
Quality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.