Skip to content

fix: correct Afrikaans language name spelling#9471

Open
decentraland-bot wants to merge 1 commit into
mainfrom
fix/afrikaans-typo
Open

fix: correct Afrikaans language name spelling#9471
decentraland-bot wants to merge 1 commit into
mainfrom
fix/afrikaans-typo

Conversation

@decentraland-bot

Copy link
Copy Markdown
Contributor

Fix typo in language list — "Afrikanns" → "Afrikaans" in the Passport language configuration asset.

@decentraland-bot
decentraland-bot requested review from a team as code owners July 23, 2026 14:55
@github-actions
github-actions Bot requested a review from anicalbano July 23, 2026 14:55
@decentraland-bot decentraland-bot added the ext-contribution Identifies a contribution which was not initiated by a Unity Developer label Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Slack notification sent to #explorer-ext-contributions for external review.
To re-send, delete this comment and re-add the ext-contribution label.

@decentraland-bot decentraland-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: fix: correct Afrikaans language name spelling

STEP 2 — Root-cause check: PASS

The PR fixes a genuine typo in the Passport language configuration asset: "Afrikanns" (double 'n') → "Afrikaans" (correct spelling). This addresses the root cause directly.

STEP 3 — Design & integration: N/A

No code changes — this is a data correction in a serialized ScriptableObject asset. No new units, lifecycle changes, subscriptions, or teardown paths introduced.

STEP 4 — Member audit: N/A

No code members added or changed.

STEP 5 — Line-level review: No issues found

The single-line change is correct. No blocking issues, no code quality concerns.

Security review: No issues found

No code changes, no new inputs, no security surface affected.

CI Status

  • Lint / watchdog: Cancelled (expected — no C# files changed)
  • Builds / Tests: Pending

ℹ️ Note: Base branch

This PR targets main. The standard branch model targets dev. This may be intentional for a simple typo fix from an external contributor — maintainers should confirm the correct target branch.

REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Single-line typo fix in a serialized configuration asset; no runtime code or systems touched.
QA_REQUIRED: NO


Reviewed by Jarvis 🤖 · Requested via Slack

@anicalbano anicalbano added the force-build Used to trigger a build on draft PR label Jul 23, 2026
@balducciv

Copy link
Copy Markdown

✅ PR reviewed and approved by QA on both platforms following the PR test instructions.
✅ Smoke test performed on Windows and Mac to verify the normal flow is working as expected.

Build: v0.159.0-alpha-fix/afrikaans-typo-c240d53
OS: Windows 11 / macOS (Apple M3 Pro)

Test results:

  • Language dropdown in Passport now displays "Afrikaans" with correct spelling on both platforms
  • Player.log confirms build matches PR commit c240d53 on both Windows and Mac

Unrelated errors noted (do not affect verdict):

  • Shutdown-time exceptions (ExitUtils/MVCManager/DynamicWorldContainer disposal) on both platforms — occur only during app quit sequence, not fix-related
  • Curl error 23: Callback aborted (Windows) — known noise on transition/abort, unrelated to this fix

Verdict: PASS ✅

Player windows 9471.log

Player 9471.log

Screenshot 2026-07-23 at 4 34 38 PM 23 07 2026_16 45 20_REC 9471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext-contribution Identifies a contribution which was not initiated by a Unity Developer force-build Used to trigger a build on draft PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants