Skip to content

fix(P4K): don't report scene websocket connect failures to Sentry #9421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eordano wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix(P4K): don't report scene websocket connect failures to Sentry #9421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...orer/Assets/DCL/Infrastructure/SceneRuntime/Apis/Modules/WebSocket/WebSocketApiWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ public object ConnectAsync(int websocketId, string url)
if (!isLocalSceneDevelopment && !url.ToLower().StartsWith("wss://"))
throw new Exception("Can't start an unsafe ws connection, please upgrade to wss. url=" + url);

return api.ConnectAsync(websocketId, url, disposeCts.Token).ReportAndRethrowException(exceptionsHandler).ToDisconnectedPromise(this);
// A failed connection to a scene-supplied endpoint is a scene-content problem, not an
// explorer defect, so it must NOT be reported to Sentry as an error (it spammed
// UNITY-EXPLORER-P4K with thousands of events). ToDisconnectedPromise still rejects the
// scene's JS connect() promise, matching how SimpleFetchApiWrapper.Fetch surfaces failures.
return api.ConnectAsync(websocketId, url, disposeCts.Token).ToDisconnectedPromise(this);
}
catch (Exception e)
{
Expand Down
Loading