feat: sdk tween 'continuous' modes#5641
Merged
Merged
Conversation
pravusjif
changed the title
This was referenced Oct 1, 2025
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
pravusjif
marked this pull request as ready for review
October 8, 2025 14:20
pravusjif
requested review from
anicalbano and
fcolarich
and removed request for
DafGreco,
mikhail-dcl and
popuz
October 8, 2025 14:20
anicalbano
approved these changes
Oct 8, 2025
anicalbano
left a comment
anicalbano
left a comment
Collaborator
There was a problem hiding this comment.
✔️ Reviewed by QA and working as expected both on Windows and Mac 😄
WINDOWS
08.10.2025_12.28.10_REC.mp4
MAC
08.10.2025_13.14.57_REC.mp4
fcolarich
reviewed
Oct 8, 2025
github-project-automation
Bot
moved this from With QA / Awaiting Review
to In Progress
in Explorer Alpha
pravusjif
enabled auto-merge (squash)
October 8, 2025 22:28
github-project-automation
Bot
moved this from With QA / Awaiting Review
to Done
in Explorer Alpha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
3 new modes for the
Tweencomponent of the SDK have been designed and are defined at this shape up document.We need that implementation on the 3 repos: Protocol, SDK, Explorer (this PR)
WHAT
PBTweencomponentTweencomponent test coverage that was a complete and utter disaster (world queries instead ofget()calls, queries not even running due to entities not having the required archetype, wront tween mode used on wron tests...) + added test coverage for the new modes.Related PRs:
TEST INSTRUCTIONS
nullrefxeption.dcl.ethScreen.Recording.2025-10-07.at.10.02.04.PM.mp4