feat: add Video component - #459
Open
braianj wants to merge 1 commit into
Open
Conversation
Deploying ui2 with
|
| Latest commit: |
191cdc3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b44039c6.ui2-423.pages.dev |
| Branch Preview URL: | https://feat-video-component.ui2-423.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a thin, autoplay-safe wrapper over a native
<video>. Consuming apps (sites) hand-roll this same element to drive background/hero videos; this promotes it into the shared library.Behavior:
playis a boolean, the component imperatively plays/pauses the element.playundefined to fall back to native attribute control (autoPlay,controls, …). All other props are forwarded to the underlying<video>.refis intentionally omitted from the public props: the component keeps its own internal ref to control playback, andHTMLProps' legacy string-ref type is incompatible with the library's strict React config.Public API (
Video,VideoProps) exported throughsrc/index.ts. Additive; no existing component or type changed. It currently has 2 in-app consumers (Create/Earn,Create/Hero), and covers a gap ui2'sAssetPreviewPlayer/Mediadon't (a bare autoplay-safe video element).Verified locally: prettier, eslint, lint:package-json,
tscbuild (strict) and the jest suite all pass. Storybook stories added (Decentraland UI/Video): native controls and imperativeplay.