feat: add Carousel component#458
Open
braianj wants to merge 1 commit into
Open
Conversation
Deploying ui2 with
|
| Latest commit: |
db12f75
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c0346500.ui2-423.pages.dev |
| Branch Preview URL: | https://feat-carousel-component.ui2-423.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic, composition-based
Carouselprimitive. Consuming apps (sites) hand-roll and re-import a single carousel implementation across several surfaces (Home rows, Create sections); this promotes it into the shared library so it stops living in app code.Behavior:
visibilitychange);autoplayDelay={0}disables it.Composition over configuration: the consumer owns each slide through
renderItem/keyExtractor, so the carousel carries no domain knowledge. Responsive slide geometry uses ui2's ownuseDesktopMediaQueryand theme breakpoints; colors come from theme tokens.Generic public API (
Carousel,CarouselProps<T>) exported throughsrc/index.ts. Additive; no existing component or type changed.Verified locally: prettier, eslint, lint:package-json,
tscbuild (strict, incl.noImplicitReturns) and the jest suite all pass. Storybook stories added (Decentraland UI/Carousel): default, autoplay-disabled, narrow slides.