feat: expose dclenv and scene-console in JumpIn desktopAppOptions#456
Merged
Conversation
Deploying ui2 with
|
| Latest commit: |
6fc7035
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19593575.ui2-423.pages.dev |
| Branch Preview URL: | https://feat-jumpin-dclenv-scenecons.ui2-423.pages.dev |
pentreathm
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JumpIncomponent'sdesktopAppOptionsprop only acceptedposition,realmandcommunityId, while the underlyinglaunchDesktopApp(src/modules/jumpIn.ts) already supportsdclenv(#441) andscene-console(#455). Consumers of the component could not forward those two deep-link params even though the primitive handles them.Changes:
desktopAppOptionsis nowPick<JumpInOptions, 'position' | 'realm' | 'communityId' | 'dclenv' | 'sceneConsole'>, so it stays in sync with the module it feeds and exposesdclenv+sceneConsole.JumpInOptionsis now exported fromsrc/modules/jumpIn.ts(flows through the existingexport *insrc/index.ts) so consumers oflaunchDesktopAppcan type the options.WithDeepLinkOptionsstory documenting the new fields.Additive and backward-compatible: every field stays optional, no existing prop or type is narrowed.
Verified locally: prettier, eslint, lint:package-json,
tscbuild and the jest suite all pass.